Re: [Intel-wired-lan] [PATCH iwl-next v4 0/7] Add PFCP filter support

[Tony Nguyen <anthony.l.nguyen@intel.com>]

On 12/7/2023 8:49 AM, Marcin Szycik wrote:
> Add support for creating PFCP filters in switchdev mode. Add pfcp module
> that allows to create a PFCP-type netdev. The netdev then can be passed to
> tc when creating a filter to indicate that PFCP filter should be created.
> 
> To add a PFCP filter, a special netdev must be created and passed to tc
> command:
> 
>    ip link add pfcp0 type pfcp
>    tc filter add dev eth0 ingress prio 1 flower pfcp_opts \
>      1:12ab/ff:fffffffffffffff0 skip_hw action mirred egress redirect \
>      dev pfcp0
> 
> Changes in iproute2 [1] are required to use pfcp_opts in tc.
> 
> ICE COMMS package is required as it contains PFCP profiles.
> 
> Part of this patchset modifies IP_TUNNEL_*_OPTs, which were previously
> stored in a __be16. All possible values have already been used, making it
> impossible to add new ones.
> 
> [1] https://lore.kernel.org/netdev/20230614091758.11180-1-marcin.szycik@linux.intel.com
> ---
> This patchset should be applied on top of the "boys" tree [2], as it
> depends on recent bitmap changes.

Is this for comment only (RFC)? This doesn't seem to apply to iwl-next 
and if this based on, and has dependencies from, another tree, I can't 
apply them here.

> [2] https://github.com/norov/linux/commits/boys
> ---
> v3: https://lore.kernel.org/intel-wired-lan/20230721071532.613888-1-marcin.szycik@linux.intel.com
> v2: https://lore.kernel.org/intel-wired-lan/20230607112606.15899-1-marcin.szycik@linux.intel.com
> v1: https://lore.kernel.org/intel-wired-lan/20230601131929.294667-1-marcin.szycik@linux.intel.com
> ---
> 
> Alexander Lobakin (3):
>    ip_tunnel: use a separate struct to store tunnel params in the kernel
>    ip_tunnel: convert __be16 tunnel flags to bitmaps
>    lib/bitmap: add tests for IP tunnel flags conversion helpers
> 
> Marcin Szycik (2):
>    ice: refactor ICE_TC_FLWR_FIELD_ENC_OPTS
>    ice: Add support for PFCP hardware offload in switchdev
> 
> Michal Swiatkowski (1):
>    pfcp: always set pfcp metadata
> 
> Wojciech Drewek (1):
>    pfcp: add PFCP module
> 
>   drivers/net/Kconfig                           |  13 +
>   drivers/net/Makefile                          |   1 +
>   drivers/net/bareudp.c                         |  19 +-
>   drivers/net/ethernet/intel/ice/ice_ddp.c      |   9 +
>   .../net/ethernet/intel/ice/ice_flex_type.h    |   4 +-
>   .../ethernet/intel/ice/ice_protocol_type.h    |  12 +
>   drivers/net/ethernet/intel/ice/ice_switch.c   |  85 +++++
>   drivers/net/ethernet/intel/ice/ice_switch.h   |   2 +
>   drivers/net/ethernet/intel/ice/ice_tc_lib.c   |  68 +++-
>   drivers/net/ethernet/intel/ice/ice_tc_lib.h   |   8 +-
>   .../ethernet/mellanox/mlx5/core/en/tc_tun.h   |   2 +-
>   .../mellanox/mlx5/core/en/tc_tun_encap.c      |   6 +-
>   .../mellanox/mlx5/core/en/tc_tun_geneve.c     |  12 +-
>   .../mellanox/mlx5/core/en/tc_tun_gre.c        |   8 +-
>   .../mellanox/mlx5/core/en/tc_tun_vxlan.c      |   9 +-
>   .../net/ethernet/mellanox/mlx5/core/en_tc.c   |  16 +-
>   .../ethernet/mellanox/mlxsw/spectrum_ipip.c   |  56 ++--
>   .../ethernet/mellanox/mlxsw/spectrum_ipip.h   |   2 +-
>   .../ethernet/mellanox/mlxsw/spectrum_span.c   |  10 +-
>   .../ethernet/netronome/nfp/flower/action.c    |  27 +-
>   drivers/net/geneve.c                          |  44 ++-
>   drivers/net/pfcp.c                            | 302 ++++++++++++++++++
>   drivers/net/vxlan/vxlan_core.c                |  14 +-
>   include/linux/netdevice.h                     |   7 +-
>   include/net/dst_metadata.h                    |  10 +-
>   include/net/flow_dissector.h                  |   2 +-
>   include/net/gre.h                             |  70 ++--
>   include/net/ip6_tunnel.h                      |   4 +-
>   include/net/ip_tunnels.h                      | 139 ++++++--
>   include/net/pfcp.h                            |  90 ++++++
>   include/net/udp_tunnel.h                      |   4 +-
>   include/uapi/linux/if_tunnel.h                |  36 +++
>   include/uapi/linux/pkt_cls.h                  |  14 +
>   lib/test_bitmap.c                             | 100 ++++++
>   net/bridge/br_vlan_tunnel.c                   |   9 +-
>   net/core/filter.c                             |  26 +-
>   net/core/flow_dissector.c                     |  20 +-
>   net/ipv4/fou_bpf.c                            |   2 +-
>   net/ipv4/gre_demux.c                          |   2 +-
>   net/ipv4/ip_gre.c                             | 144 +++++----
>   net/ipv4/ip_tunnel.c                          | 109 +++++--
>   net/ipv4/ip_tunnel_core.c                     |  82 +++--
>   net/ipv4/ip_vti.c                             |  41 ++-
>   net/ipv4/ipip.c                               |  33 +-
>   net/ipv4/ipmr.c                               |   2 +-
>   net/ipv4/udp_tunnel_core.c                    |   5 +-
>   net/ipv6/addrconf.c                           |   3 +-
>   net/ipv6/ip6_gre.c                            |  85 ++---
>   net/ipv6/ip6_tunnel.c                         |  14 +-
>   net/ipv6/sit.c                                |  38 ++-
>   net/netfilter/ipvs/ip_vs_core.c               |   6 +-
>   net/netfilter/ipvs/ip_vs_xmit.c               |  20 +-
>   net/netfilter/nft_tunnel.c                    |  44 +--
>   net/openvswitch/flow_netlink.c                |  61 ++--
>   net/psample/psample.c                         |  26 +-
>   net/sched/act_tunnel_key.c                    |  36 +--
>   net/sched/cls_flower.c                        | 134 +++++++-
>   57 files changed, 1652 insertions(+), 495 deletions(-)
>   create mode 100644 drivers/net/pfcp.c
>   create mode 100644 include/net/pfcp.h
>