From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ED383A6414 for ; Wed, 8 Apr 2026 08:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775637356; cv=none; b=fzeKI5V6heqw4GBDepkmioBN5LuaQazeOEDE1qoy69Gdo12/mFN/6sD05v96f7itkXKnBXCdw1VsJgKTXRRHN0xBUEU6aFsn3x9eICPdMwQmZ0aGbQhyIU/u0GrX92rvm8frW38GTy4QW2eMVvcGqQWtMuIaLVsDEi4Eo8ediQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775637356; c=relaxed/simple; bh=/j/mCKzNC16wLgMFAQX3HI7G9C2VVWHKb4dZodwbG30=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DdtNhh3ZQ0zTBILawhc9GSlyVA0LkJXFwla49hDXgS27TRjeToxkMxqiakmx/cPksB0MOLKGMCl4Rd2pDk1smfeB5ISXePHrnyxQwXrV3ZZLoPYFGPQ8q2SKhneccLnE8AyZHmAlI7/D8J4o9X+TBbemYVUhF93Y72Pn1gFX5Hw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ehVqOdBE; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ehVqOdBE" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so54997725e9.0 for ; Wed, 08 Apr 2026 01:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775637354; x=1776242154; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v3TQJY5IlXJsbG9+wxNqKMgJ09GA4sRxRbi0tKG232I=; b=ehVqOdBEr1OP0RKwOob8OvZVNt5QHEkq93+8FZehX/CBNGzd3jrNcELBvZMnKj2CP3 /+BUiexQ4qBlFnELExQfwwpum3KRrjGn459QdSgTCuL3mT6lQ9+5qnCa1nE0mLyuYqX2 C0bV5DX2FIsC+3O5T+M4yhmbYi7MDuZUsw7y8k7U76Fmv8peYaDMhKuUvGHsEhlopANZ Bxnk+Fx9l8FZze5YXtObBQiJ4GTxoD5AAjlzBrQQu7wuSdv+7EOOcij34wYYgnv7K0ca S0o3tnjc1+x+t/lmVN3moYQEf57YQjftnae/4PVLsoO6gZnnZ1hUhkQf4v85ntCrbzli L5ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775637354; x=1776242154; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v3TQJY5IlXJsbG9+wxNqKMgJ09GA4sRxRbi0tKG232I=; b=iI9tkCCBxQ7YQJQYyUd8Xrn1NUanTy9rTw0ZayQQDE0CmiCfni9NEUccm49pskM2yP RSza4n6q80C+yDvAtqCRM6GetQTiAT1D5TeiwXtHRZ6Ub5NDGg0RKDWTBJgpkNkNzBd3 gI4qCip32tGXjEDoc3VuTk5ex8nfDd+LIE2VZnctGbKbJes6GySCzBD7KCXZbP+z9mfi 9o8qjEVrbk9NRVMnUV0jpQL6qOfkG29QTT0Gi92qdO0YAY1nt7VYyihZc3bGBPPigz3G 9CRdOges65s9s+aX71+Fu2PDuJo+iSPgeH/gKH8/Dr/PxPBtohijvHDHAZ2My1C2tugD D6cg== X-Forwarded-Encrypted: i=1; AJvYcCXHCovg7Puo9/47ZV77fbqu7jDz1qyeohAPiidcYmy+SgGibxcsf/+LJLDYNBCpOFWTX7mT7Nw=@vger.kernel.org X-Gm-Message-State: AOJu0YweFxQEap0WCzzCYKxKv7wEvGL3U3J7kGKxIm23e+Bic6J4wwgJ B86RolxF1qMzDbfZM2d0qJebMPueFIUBxBT62xZo9wltVqzAaN2TEI9A X-Gm-Gg: AeBDiev3+crie3gxRpYZdTVG5jskOemrPPIbEbgo6XyWQqj67y9MxWI/IJC/ZcAboWM MpZw0QGs1mkulvybOVYYyWVH72QgxZnzd5guB9/f/ZguQNFlkYqrFg9iaa9JoCsNSldETs5YAWs QUG1spP9emScXKkF1qYwkFMWVZw4o/mUc8UvWBgL/dSy0ZUC+pVc1qseV2vwdzwuEVnJGf892iz ivFzsaeyl3RxlPjp1h5eaIKO0xl7PY1/iOuV6sqEfjRulhZ6BeZULlhFSy1AnqSc1p4Vg7akS5A bFiLgzPpDjKnen3AHm6C5LtMyMbFqBC3nA3KMIuDysD2NZRTG6sd6KiJ0Hq6m0swvF/y7F8Vdbw 0aCfwmQkoN7VCUnCdOdgy5SP6RXw6zwjkhgkkV+6JUzxzIKSzLJLoK7unakNdeH3NfpeLrdpqYx KfoBOnj5w3gUj7FqFcNNDjSZYyRrFdKr35cQq1o2SDRoENo3eh+yOf5VXgoseCCpE/9Lkr5Q9Me aQufWd9DAdQJ7ZabpV2UFtIGvHvmj5aES8/xCpN2cGkFDk0ZXtxXOCNZ0I= X-Received: by 2002:a05:600c:4b23:b0:488:a723:ea53 with SMTP id 5b1f17b1804b1-488a723ebddmr118522865e9.7.1775637353943; Wed, 08 Apr 2026 01:35:53 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325:77fd:1068:74c8:af87? ([2620:10d:c092:600::1:eaba]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488be75215dsm119684505e9.6.2026.04.08.01.35.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 01:35:53 -0700 (PDT) Message-ID: Date: Wed, 8 Apr 2026 09:35:58 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] io_uring/rsrc: use io_cache_free for node in io_buffer_register_bvec error path To: KobaK , Jens Axboe Cc: Keith Busch , Ming Lei , io-uring@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260408065408.2017967-1-kobak@nvidia.com> <20260408065408.2017967-3-kobak@nvidia.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20260408065408.2017967-3-kobak@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/8/26 07:54, KobaK wrote: > From: Koba Ko > > io_buffer_register_bvec() allocates the rsrc node via > io_rsrc_node_alloc() which pulls from ctx->node_cache. On imu allocation > failure, the node is freed with raw kfree() instead of > io_cache_free(&ctx->node_cache, node), bypassing the cache return path > and wasting a reuse opportunity. Every other error path in this file > correctly uses io_cache_free for nodes. > > Fixes: 27cb27b6d5ea4 ("io_uring: add support for kernel registered bvecs") > Signed-off-by: Koba Ko > --- > io_uring/rsrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c > index 1b96ab5e98c99..6f46cf9cd13d7 100644 > --- a/io_uring/rsrc.c > +++ b/io_uring/rsrc.c > @@ -961,7 +961,7 @@ int io_buffer_register_bvec(struct io_uring_cmd *cmd, struct request *rq, > */ > imu = io_alloc_imu(ctx, blk_rq_nr_phys_segments(rq)); > if (!imu) { > - kfree(node); > + io_cache_free(&ctx->node_cache, node); Looks like it was already patched a week ago -- Pavel Begunkov