From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Subject: Re: [PATCH] ixgbe: fix Kconfig when driver is not a module Date: Thu, 03 Jan 2019 13:42:20 -0800 Message-ID: References: <20190103213519.9754-1-jeffrey.t.kirsher@intel.com> Reply-To: jeffrey.t.kirsher@intel.com Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-PRDFrJ24/Ni4g8+o8PYb" Cc: netdev@vger.kernel.org, Dave Jones , Steve Douthit , Florian Fainelli To: intel-wired-lan@lists.osuosl.org Return-path: Received: from mga01.intel.com ([192.55.52.88]:54788 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727243AbfACVmW (ORCPT ); Thu, 3 Jan 2019 16:42:22 -0500 In-Reply-To: <20190103213519.9754-1-jeffrey.t.kirsher@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: --=-PRDFrJ24/Ni4g8+o8PYb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2019-01-03 at 13:35 -0800, Jeff Kirsher wrote: > The new ability added to the driver to use mii_bus to handle MII > related > ioctls is causing compile issues when the driver is compiled into the > kernel (i.e. not a module). >=20 > The simple solution of requiring the driver to be compiled as a > module when > MDIO_BUS is a module, causes a recursion Kconfig issue due to IPSec > dependencies. >=20 > So created another Kconfig option for ixgbe, to enable mdio_bus > support for > DSA devices. This solution solves the problem when the ixgbe driver > is > compiled into the kernel and MDIO_BUS is compiled as a module. In > this > case, the IXGBE_MDIO option is disabled and the code is not compiled > into the driver. >=20 > CC: Dave Jones > CC: Steve Douthit > CC: Florian Fainelli > Signed-off-by: Jeff Kirsher > --- > drivers/net/ethernet/intel/Kconfig | 11 ++++++++++- > drivers/net/ethernet/intel/ixgbe/ixgbe.h | 4 ++++ > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 12 ++++++++++-- > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 4 ++++ > drivers/net/ethernet/intel/ixgbe/ixgbe_phy.h | 3 ++- > 5 files changed, 30 insertions(+), 4 deletions(-) I have done the following compile tests to comfirm this resolves the issue: Kconfig: 1 2 3 4 -------- --- --- --- --- ixgbe m m y y ixgbe_mdio y n y y mdio_bus m m m y phylib m m m y Test #3 resulted in ixgbe_mdio being disabled and code not compiled into the driver. --=-PRDFrJ24/Ni4g8+o8PYb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlwugbwACgkQ5W/vlVpL 7c4KnA//fqHvw7dhacWbqGZ+qrbfIIO0vAlKNmU3K9TZz/HZfPcLthoWZZxQkchT dnErukTqqJoefKX51gHGpk5nlcAfjY5XPGVT7gePHSvRyYUHv1SQx664zHPPngc5 GMyb5AASGfMsI2sNu/f0YEOUjN5b3r7fbuZRUUvHgUzxH142HsR0F0TbwPm57dye +RPqmYaCFgAwnKn/e3dKDwKyGIv/TLqSu4E+nA+GIFdCDe0oxSQ2RjL3OX2wW/Oo 8T2UqoP1R3KjFzQPssdUA8nnoW/Esc/fwIdOqVFMAfK+/QGxO+UjWrIGP8bkocEE yFksdcVr+Vl9NchkRnWFyU9qI4PkjZmhludSMMdyTXzejdIsZI8HcJ47vsnyPfXq XJKx1h2pHZVuWNGayZd7SllxL5DD8oNb/tEtWp/jO++adE3LTCd5Igd2Exmo8tG2 Okx7kHcdC/hGuWQbdrJ2bDwNzlzZ+H+cMyWck8NGXJ/FwC2aq1DgN4U98v7djGD1 DCl5vcnsDoJYhRzMzAnzdIqkAzDGgKgU8R/c9aPcJnPHeiz4IG+/4h2SHgZTOxtt bUlhe4YA2Whg3vCi0nw3JKxtjmT/FbSsUpObfd8LbVzxKnjt1lhFxwkKN/ZkfilP 4IFhysgDah1AJzTg73sZZ5mKd1qZal1D1u2FSNtkn72yMnzUrfo= =98tS -----END PGP SIGNATURE----- --=-PRDFrJ24/Ni4g8+o8PYb--