Re: [Intel-wired-lan] [PATCH iwl-next] i40e: PTP: set supported flags in ptp_clock_info

[Dawid Osuchowski <dawid.osuchowski@linux.intel.com>]

On 2026-03-09 3:11 PM, Przemyslaw Korba wrote:
> Since upstream commit d9f3e9ecc456 ("net: ptp: introduce
> .supported_perout_flags to ptp_clock_info") and commit 7c571ac57d9d ("net:
> ptp: introduce .supported_extts_flags to ptp_clock_info"), kernel core now
> requires that the driver set the .supported_perout_flags and
> .supported_extts_flags fields in PTP clock info. Otherwise, the additional
> flags will be rejected by the kernel automatically.
> 
> i40e does not support perout flags, so reject any request with perout
> flags.
> 
> Signed-off-by: Przemyslaw Korba <przemyslaw.korba@intel.com>

Hey Przemek,

**Please don't circumvent our established process of going through 
internal review before posting to iwl**. You should send to our internal 
mailing list and get at least one Reviewed-by tag first, before posting 
to iwl. I think we make exceptions only when there is a strict time 
constraint and need to get the change out FAST (e.g. bug present in 
Tony's tree or netdev but not in Linus' tree yet). Reach out internally 
if you don't know the process and I can share the proper resources.

> ---
>   drivers/net/ethernet/intel/i40e/i40e_ptp.c | 12 +++++++++++-
>   1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_ptp.c b/drivers/net/ethernet/intel/i40e/i40e_ptp.c
> index 7bcea7d9720f..8d7958692235 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_ptp.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_ptp.c
> @@ -601,10 +601,18 @@ static int i40e_ptp_feature_enable(struct ptp_clock_info *ptp,
>   	/* TODO: Implement flags handling for EXTTS and PEROUT */

Ignoring Simon's comment (not because it doesn't have merit, but because 
I don't know this part of the driver and the referenced patches), given 
you just seem to have implemented setting (or maybe handling) these 
flags in this commit, might be the time to remove this TODO comment? :)

-Dawid