From: Davide Caratti <dcaratti@redhat.com>
To: linux-sctp@vger.kernel.org, netdev@vger.kernel.org
Cc: Alexander Duyck <alexander.duyck@gmail.com>,
Tom Herbert <tom@herbertland.com>,
David Laight <David.Laight@ACULAB.COM>,
"David S. Miller" <davem@davemloft.net>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: [PATCH net-next v2 7/7] sk_buff.h: improve description of CHECKSUM_{COMPLETE,UNNECESSARY}
Date: Tue, 16 May 2017 18:27:51 +0200 [thread overview]
Message-ID: <b44a70a3e512f0121f52dbf9683bf2d25f7e1941.1494946940.git.dcaratti@redhat.com> (raw)
In-Reply-To: <cover.1494946940.git.dcaratti@redhat.com>
Add FCoE to the list of protocols that can set CHECKSUM_UNNECESSARY; add a
note to CHECKSUM_COMPLETE section to specify that it does not apply to SCTP
and FCoE protocols.
Suggested-by: Tom Herbert <tom@herbertland.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Acked-by: Tom Herbert <tom@herbertland.com>
---
include/linux/skbuff.h | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index fe109fa..5a082db 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -109,6 +109,7 @@
* may perform further validation in this case.
* GRE: only if the checksum is present in the header.
* SCTP: indicates the CRC in SCTP header has been validated.
+ * FCOE: indicates the CRC in FC frame has been validated.
*
* skb->csum_level indicates the number of consecutive checksums found in
* the packet minus one that have been verified as CHECKSUM_UNNECESSARY.
@@ -126,8 +127,10 @@
* packet as seen by netif_rx() and fills out in skb->csum. Meaning, the
* hardware doesn't need to parse L3/L4 headers to implement this.
*
- * Note: Even if device supports only some protocols, but is able to produce
- * skb->csum, it MUST use CHECKSUM_COMPLETE, not CHECKSUM_UNNECESSARY.
+ * Notes:
+ * - Even if device supports only some protocols, but is able to produce
+ * skb->csum, it MUST use CHECKSUM_COMPLETE, not CHECKSUM_UNNECESSARY.
+ * - CHECKSUM_COMPLETE is not applicable to SCTP and FCoE protocols.
*
* CHECKSUM_PARTIAL:
*
--
2.7.4
prev parent reply other threads:[~2017-05-16 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 16:27 [PATCH net-next v2 0/7] fix CRC32c in the forwarding path Davide Caratti
2017-05-16 16:27 ` [PATCH net-next v2 1/7] skbuff: add stub to help computing crc32c on SCTP packets Davide Caratti
2017-05-17 16:08 ` David Miller
2017-05-16 16:27 ` [PATCH net-next v2 2/7] net: introduce skb_crc32c_csum_help Davide Caratti
2017-05-16 16:27 ` [PATCH net-next v2 3/7] sk_buff: remove support for csum_bad in sk_buff Davide Caratti
2017-05-16 16:27 ` [PATCH net-next v2 4/7] net: use skb->csum_not_inet to identify packets needing crc32c Davide Caratti
2017-05-16 16:27 ` [PATCH net-next v2 5/7] net: more accurate checksumming in validate_xmit_skb() Davide Caratti
2017-05-16 16:27 ` [PATCH net-next v2 6/7] openvswitch: more accurate checksumming in queue_userspace_packet() Davide Caratti
2017-05-16 16:27 ` Davide Caratti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b44a70a3e512f0121f52dbf9683bf2d25f7e1941.1494946940.git.dcaratti@redhat.com \
--to=dcaratti@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).