From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3EC3383C7C for ; Mon, 20 Apr 2026 19:02:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776711780; cv=none; b=gBh8VUacZC/vsEh9JbP0zh/2aEbGGH9n7ZVSApEXvUDUHsh3q7RghDXtqtnF2MxdNgoBiQ60kFYo8gO+eoc1RFzy7nplaU/w6NoGnvb4NZT7Q2GGTuvDcmi/g3XoFGG4tfWddJu3BkmIdif4ONGdZ/URwoOosL6LznkpPHyzHP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776711780; c=relaxed/simple; bh=gDW+UqMClfGLo+WdeMypawSnkwG8D7oGaoBZ3MCNExw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=O+cRZe71zgCFRxx607g36+f2XnqZB7EbRiw9Swtm7MU/YxbtDGDq92ZPO1DF27G97am919Fyuc/2LKgOakr62KXl6rQqauqFc8D+9pcCZ7Bobuwhy8PCNC239Ze1aAn0HjFo/Cq7fsW7oWatxlPqjKCG7lYWb4sU9MooZdIozU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dtmI+/pI; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dtmI+/pI" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-48374014a77so44193495e9.3 for ; Mon, 20 Apr 2026 12:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776711777; x=1777316577; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N65t9jImbyCGiHKfgsqjeriV0Rsv4zHSWcdJpEICw7c=; b=dtmI+/pInlCCbIq3KwApvUgqncnj+XsrcbVz7nDv3PPZm8+Yb7BJTQX8Qih53Fw4oh YzI7c8GJhDMzJGt4peeKK0TKL9Ig8QvupwXM6sN1TzqLRYQgaqQ0BWjfUimPphL4MNss MOjZON1LETxjXMLbz8Wk4xXdvTbj9kMPZ2hlIvzr7kkUXColJFwmHVMuXqARzgLLUZpN fAJiD0Ji9wAEPSJTkVN419fAw8Nh5WZT095Mv1hY7nNsM3kmyK9TP9wWuQl1aet7d806 vbi546WDCyXDNCP5694Cnlc59OAS1Q1HgF/1JiMcc0Ekf3siH8eQ654ySxnK3G5sqbWj tw7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776711777; x=1777316577; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N65t9jImbyCGiHKfgsqjeriV0Rsv4zHSWcdJpEICw7c=; b=Paa32+JxzeUs1OD9eSLJIxe/FSJJNNCZYp35V6hc0SMQgjqHQ8kUxBzW5k9orp0yZs UVMH98HPVDmd2GZxSrAoy5zUJOEhTn1kjcdJKWLoUb11rNpnGZTx0EG2WASvaNaNEp5J dYVPScMQ+aDhkSiZnTFpEmiJvlHAofIVhvTmuXiudW8FpIcLUdMuJmzJAvg78Moy++9+ S/18iEEQ1KnG4Le63mYK/RJvDQY8b4NLWit69SDnTM0nIzhWQGxxl683vURD45Vgbt+1 Tbo1d1b4+4mda4qGEL/N4o4Ko2xsvAyiFGaaufsNNFFhTFykJVYY8VniHQDnvLqbFPBf TRjQ== X-Forwarded-Encrypted: i=1; AFNElJ9mZCJLueFq+GqZBHCiBgp81qv8lJc7TKKreMVkFbi0SJ8HakoDVpaG86jUvButJBy7Z1lZQ64=@vger.kernel.org X-Gm-Message-State: AOJu0YzY98no0OozmPWGqyaUaPlxXhPNPFyRjSkR0y5/TqUiN/2TS3qD b5PPf9IDpviaDwCr01urGEix49mFg9ELje9rzusbqlijB/5hY6L82imX X-Gm-Gg: AeBDietZT4rFqHOO/X5Tc6sMOghAc1UDDSIXVUCa7sp5F8kqYOohLm2gaxbPi0aTPK4 5jb1AL7MSt3lNei0Otfm1kgYGTx5vDZsFMmHhEVqvX8P7Q7Vh9BKswrgS6bRXzoQjg78chDOb3Y QwtXTcsImsimQT8Tpo41EZIPugbd/yw5ErYnxi2PIK6eslh6BWBwmn8EH/10St3hSZ1vWt8qJI4 8E/Ydno4r/gVk6yb85Om9VtnRnPWdAeVwmr7pd2XcRBikaFtl0LVNCS+oi4UlZKjdWlkwGKLMNi wwpbI39FToqV2/40darR+O+F4hUjU6NoWeB9KAhp9Xo+rP8XWGBZ3loItLG4n0ETGX5nB/DSN9C HPRjvWPDuIqruTeWWAqTYxv2hiI3vGPos7wHdrz5OsCk24gGgqPEYz2MPksYF57YFKsw263Tg38 rT6MCURgJP6FjRZ4RDGxSt0IFdW/fNEMOPKwkRbQg/tOU1KIZLgu+EWLRfAUy7am/LNM8FsWVnI lIwMiTqhJBKLOYs X-Received: by 2002:a05:600c:348b:b0:489:5022:39a4 with SMTP id 5b1f17b1804b1-4895040c025mr56054525e9.9.1776711776741; Mon, 20 Apr 2026 12:02:56 -0700 (PDT) Received: from ?IPV6:2a02:a03f:a75e:9a00:98a0:d751:7986:3f62? ([2a02:a03f:a75e:9a00:98a0:d751:7986:3f62]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc177dafsm378108875e9.4.2026.04.20.12.02.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2026 12:02:56 -0700 (PDT) Message-ID: Date: Mon, 20 Apr 2026 21:02:55 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gtp: disable BH before calling udp_tunnel_xmit_skb() To: David Carlier , Pablo Neira Ayuso , Harald Welte , Andrew Lunn , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Weiming Shi , osmocom-net-gprs@lists.osmocom.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260417055408.4667-1-devnexen@gmail.com> Content-Language: en-US From: Justin Iurman In-Reply-To: <20260417055408.4667-1-devnexen@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/17/26 07:54, David Carlier wrote: > gtp_genl_send_echo_req() runs as a generic netlink doit handler in > process context with BH not disabled. It calls udp_tunnel_xmit_skb(), > which eventually invokes iptunnel_xmit() — that uses __this_cpu_inc/dec > on softnet_data.xmit.recursion to track the tunnel xmit recursion level. > > Without local_bh_disable(), the task may migrate between > dev_xmit_recursion_inc() and dev_xmit_recursion_dec(), breaking the > per-CPU counter pairing. The result is stale or negative recursion > levels that can later produce false-positive > SKB_DROP_REASON_RECURSION_LIMIT drops on either CPU. > > The other udp_tunnel_xmit_skb() call sites in gtp.c are unaffected: > the data path runs under ndo_start_xmit and the echo response handlers > run from the UDP encap rx softirq, both with BH already disabled. > > Fix it by disabling BH around the udp_tunnel_xmit_skb() call, mirroring > commit 2cd7e6971fc2 ("sctp: disable BH before calling > udp_tunnel_xmit_skb()"). Why not fix iptunnel_xmit() directly, rather than fixing all possible callers? Basically, jut like we did for lwtunnel_{output|xmit}(). The advantage would be that we no longer have to worry about BHs in the callers, and BHs would only be disabled when necessary.