Re: [RFC Patch net-next v1 8/9] r8169: move struct ethtool_ops

Andrew Lunn
2026-04-20T14:33:44Z

On Mon, Apr 20, 2026 at 10:19:56AM +0800, javen wrote:
> From: Javen Xu <javen_xu@realsil.com.cn>
>
> This patch move struct ethtool_ops, no changes. Prepare for next patch.

Commit messages are all about "Why?". You normally move code because a
local function is after where it will be called from. I assume your
next patch is going to add a function which will be listed in the
ethtool ops, and it calls a function which is currently after the
ethtool ops. Please name names.

Andrew

---
pw-bot: cr