From: Alexandra Winter <wintera@linux.ibm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jori Koolstra <jkoolstra@xs4all.nl>
Cc: "open list:DIBS (DIRECT INTERNAL BUFFER SHARING)"
<netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dibs: change dibs_class to a const struct
Date: Tue, 3 Mar 2026 14:07:41 +0100 [thread overview]
Message-ID: <b4804b53-c25c-485e-8cb3-9ade70a6f625@linux.ibm.com> (raw)
In-Reply-To: <2026030246-savor-hardener-6102@gregkh>
On 02.03.26 23:54, Greg Kroah-Hartman wrote:
> On Mon, Mar 02, 2026 at 05:31:03PM +0100, Jori Koolstra wrote:
>> The class_create() call has been deprecated in favor of class_register()
>> as the driver core now allows for a struct class to be in read-only
>> memory. Change dibs_class to be a const struct class and drop the
>> class_create() call.
>>
>> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Signed-off-by: Jori Koolstra <jkoolstra@xs4all.nl>
>> ---
>> drivers/dibs/dibs_main.c | 14 ++++++++------
>> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Thank you for the patch Jori.
Would you mind adding a link to explain the "as the driver core now allows"?
Maybe
Link: https://lore.kernel.org/all/2023040248-outrage-obsolete-5a9a@gregkh/
For my education: How could I have noticed that class_create() call has been deprecated?
Is that marked somewhere somehow?
next prev parent reply other threads:[~2026-03-03 13:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 16:31 [PATCH] dibs: change dibs_class to a const struct Jori Koolstra
2026-03-02 22:54 ` Greg Kroah-Hartman
2026-03-03 13:07 ` Alexandra Winter [this message]
2026-03-03 13:23 ` Jori Koolstra
2026-03-03 13:38 ` Alexandra Winter
2026-03-03 13:47 ` Jori Koolstra
2026-03-03 14:47 ` Alexandra Winter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4804b53-c25c-485e-8cb3-9ade70a6f625@linux.ibm.com \
--to=wintera@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jkoolstra@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox