From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84C85C63798 for ; Wed, 18 Nov 2020 13:57:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AEE120872 for ; Wed, 18 Nov 2020 13:57:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726477AbgKRN5S (ORCPT ); Wed, 18 Nov 2020 08:57:18 -0500 Received: from mxout70.expurgate.net ([194.37.255.70]:53307 "EHLO mxout70.expurgate.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbgKRN5R (ORCPT ); Wed, 18 Nov 2020 08:57:17 -0500 Received: from [127.0.0.1] (helo=localhost) by relay.expurgate.net with smtp (Exim 4.90) (envelope-from ) id 1kfNxM-0006lO-Tk; Wed, 18 Nov 2020 14:57:08 +0100 Received: from [195.243.126.94] (helo=securemail.tdt.de) by relay.expurgate.net with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90) (envelope-from ) id 1kfNxL-0004WC-U6; Wed, 18 Nov 2020 14:57:07 +0100 Received: from securemail.tdt.de (localhost [127.0.0.1]) by securemail.tdt.de (Postfix) with ESMTP id 188BB240041; Wed, 18 Nov 2020 14:57:04 +0100 (CET) Received: from mail.dev.tdt.de (unknown [10.2.4.42]) by securemail.tdt.de (Postfix) with ESMTP id 8DE49240040; Wed, 18 Nov 2020 14:57:03 +0100 (CET) Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 2B85220370; Wed, 18 Nov 2020 14:57:02 +0100 (CET) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 18 Nov 2020 14:57:02 +0100 From: Martin Schiller To: Xie He Cc: Andrew Hendry , "David S. Miller" , Jakub Kicinski , Linux X25 , Linux Kernel Network Developers , LKML Subject: Re: [PATCH net-next v2 5/6] net/lapb: support netdev events Organization: TDT AG In-Reply-To: References: <20201116135522.21791-1-ms@dev.tdt.de> <20201116135522.21791-6-ms@dev.tdt.de> Message-ID: X-Sender: ms@dev.tdt.de User-Agent: Roundcube Webmail/1.3.15 X-purgate-type: clean X-purgate: clean X-purgate-ID: 151534::1605707828-00000FB8-740E6CBA/0/0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2020-11-18 14:46, Xie He wrote: > On Wed, Nov 18, 2020 at 5:03 AM Xie He wrote: >> >> On Wed, Nov 18, 2020 at 12:49 AM Martin Schiller >> wrote: >> > >> > I also have a patch here that implements an "on demand" link feature, >> > which we used for ISDN dialing connections. >> > As ISDN is de facto dead, this is not relevant anymore. But if we want >> > such kind of feature, I think we need to stay with the method to control >> > L2 link state from L3. >> >> I see. Hmm... >> >> I guess for ISDN, the current code (before this patch series) is the >> best. We only establish the connection when L3 has packets to send. >> >> Can we do this? We let L2 handle all device-up / device-down / >> carrier-up / carrier-down events. And when L3 has some packets to send >> but it still finds the L2 link is not up, it will then instruct L2 to >> connect. >> >> This way we may be able to both keep the logic simple and still keep >> L3 compatible with ISDN. > > Another solution might be letting ISDN automatically connect when it > receives the first packet from L3. This way we can still free L3 from > all handlings of L2 connections. ISDN is not important now. Also the I4L subsystem has been removed. I have now completely reworked the patch-set and it is now much tidier. For now I left the event handling completely in X.25 (L3). I will now send the whole thing as v3 and we can discuss it further.