* [PATCH net] sunhme: fix an IS_ERR() vs NULL check in probe
@ 2022-10-12 15:01 Dan Carpenter
2022-10-12 15:52 ` Sean Anderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dan Carpenter @ 2022-10-12 15:01 UTC (permalink / raw)
To: Sean Anderson
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rolf Eike Beer, netdev, kernel-janitors
The devm_request_region() function does not return error pointers, it
returns NULL on error.
Fixes: 914d9b2711dd ("sunhme: switch to devres")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/sun/sunhme.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
index 62deed210a95..91f10f746dff 100644
--- a/drivers/net/ethernet/sun/sunhme.c
+++ b/drivers/net/ethernet/sun/sunhme.c
@@ -2896,8 +2896,8 @@ static int happy_meal_pci_probe(struct pci_dev *pdev,
hpreg_res = devm_request_region(&pdev->dev, pci_resource_start(pdev, 0),
pci_resource_len(pdev, 0), DRV_NAME);
- if (IS_ERR(hpreg_res)) {
- err = PTR_ERR(hpreg_res);
+ if (!hpreg_res) {
+ err = -EBUSY;
dev_err(&pdev->dev, "Cannot obtain PCI resources, aborting.\n");
goto err_out_clear_quattro;
}
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] sunhme: fix an IS_ERR() vs NULL check in probe
2022-10-12 15:01 [PATCH net] sunhme: fix an IS_ERR() vs NULL check in probe Dan Carpenter
@ 2022-10-12 15:52 ` Sean Anderson
2022-10-13 9:05 ` Rolf Eike Beer
2022-10-13 16:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Sean Anderson @ 2022-10-12 15:52 UTC (permalink / raw)
To: Dan Carpenter
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rolf Eike Beer, netdev, kernel-janitors
On 10/12/22 11:01, Dan Carpenter wrote:
> The devm_request_region() function does not return error pointers, it
> returns NULL on error.
>
> Fixes: 914d9b2711dd ("sunhme: switch to devres")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/sun/sunhme.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
> index 62deed210a95..91f10f746dff 100644
> --- a/drivers/net/ethernet/sun/sunhme.c
> +++ b/drivers/net/ethernet/sun/sunhme.c
> @@ -2896,8 +2896,8 @@ static int happy_meal_pci_probe(struct pci_dev *pdev,
>
> hpreg_res = devm_request_region(&pdev->dev, pci_resource_start(pdev, 0),
> pci_resource_len(pdev, 0), DRV_NAME);
> - if (IS_ERR(hpreg_res)) {
> - err = PTR_ERR(hpreg_res);
> + if (!hpreg_res) {
> + err = -EBUSY;
> dev_err(&pdev->dev, "Cannot obtain PCI resources, aborting.\n");
> goto err_out_clear_quattro;
> }
Reviewed-by: Sean Anderson <seanga2@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] sunhme: fix an IS_ERR() vs NULL check in probe
2022-10-12 15:01 [PATCH net] sunhme: fix an IS_ERR() vs NULL check in probe Dan Carpenter
2022-10-12 15:52 ` Sean Anderson
@ 2022-10-13 9:05 ` Rolf Eike Beer
2022-10-13 16:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Rolf Eike Beer @ 2022-10-13 9:05 UTC (permalink / raw)
To: Sean Anderson, Dan Carpenter
Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
Am Mittwoch, 12. Oktober 2022, 17:01:32 CEST schrieb Dan Carpenter:
> The devm_request_region() function does not return error pointers, it
> returns NULL on error.
>
> Fixes: 914d9b2711dd ("sunhme: switch to devres")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] sunhme: fix an IS_ERR() vs NULL check in probe
2022-10-12 15:01 [PATCH net] sunhme: fix an IS_ERR() vs NULL check in probe Dan Carpenter
2022-10-12 15:52 ` Sean Anderson
2022-10-13 9:05 ` Rolf Eike Beer
@ 2022-10-13 16:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-13 16:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: seanga2, davem, edumazet, kuba, pabeni, eike-kernel, netdev,
kernel-janitors
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 12 Oct 2022 18:01:32 +0300 you wrote:
> The devm_request_region() function does not return error pointers, it
> returns NULL on error.
>
> Fixes: 914d9b2711dd ("sunhme: switch to devres")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/sun/sunhme.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary with links:
- [net] sunhme: fix an IS_ERR() vs NULL check in probe
https://git.kernel.org/netdev/net/c/99df45c9e0a4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-13 16:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-12 15:01 [PATCH net] sunhme: fix an IS_ERR() vs NULL check in probe Dan Carpenter
2022-10-12 15:52 ` Sean Anderson
2022-10-13 9:05 ` Rolf Eike Beer
2022-10-13 16:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).