From: Florian Fainelli <f.fainelli@gmail.com>
To: Tristram.Ha@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Pavel Machek <pavel@ucw.cz>,
Ruediger Schmitt <ruediger.schmitt@philips.com>
Cc: muvarov@gmail.com, nathan.leigh.conrad@gmail.com,
vivien.didelot@savoirfairelinux.com,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] Add other KSZ switch support so that patch check does not complain
Date: Wed, 11 Oct 2017 14:18:02 -0700 [thread overview]
Message-ID: <b4acd408-0f36-2050-b8c4-9eb46e6da92f@gmail.com> (raw)
In-Reply-To: <1507322009-15142-1-git-send-email-Tristram.Ha@microchip.com>
On 10/06/2017 01:33 PM, Tristram.Ha@microchip.com wrote:
> From: Tristram Ha <Tristram.Ha@microchip.com>
>
> Add other KSZ switch support so that patch check does not complain.
You are not doing this just so checkpatch.pl stops complaining, what you
are doing here is to properly document the possible models supported by
this binding document.
Please also use a proper subject for this patch:
dt-bindings: dsa: Document additional Micrel KSZ family switches
or something along those lines.
With that:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
prev parent reply other threads:[~2017-10-11 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 20:33 [PATCH RFC] Add other KSZ switch support so that patch check does not complain Tristram.Ha
2017-10-11 20:46 ` Pavel Machek
2017-10-11 21:18 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4acd408-0f36-2050-b8c4-9eb46e6da92f@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Tristram.Ha@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=muvarov@gmail.com \
--cc=nathan.leigh.conrad@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=ruediger.schmitt@philips.com \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).