From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next 08/12] net: ethernet: Add helper for MACs which support asym pause Date: Mon, 3 Sep 2018 10:38:12 -0700 Message-ID: References: <1535908001-18593-1-git-send-email-andrew@lunn.ch> <1535908001-18593-9-git-send-email-andrew@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev , maxime.chevallier@bootlin.com To: Andrew Lunn , David Miller Return-path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:43234 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726384AbeICV7f (ORCPT ); Mon, 3 Sep 2018 17:59:35 -0400 Received: by mail-pg1-f196.google.com with SMTP id v66-v6so438784pgb.10 for ; Mon, 03 Sep 2018 10:38:25 -0700 (PDT) In-Reply-To: <1535908001-18593-9-git-send-email-andrew@lunn.ch> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 9/2/2018 10:06 AM, Andrew Lunn wrote: > Rather than have the MAC drivers manipulate phydev members to indicate > they support Asym Pause, add a helper function. > > Signed-off-by: Andrew Lunn Reviewed-by: Florian Fainelli Just one nit in tg3.c: > diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c > index eab00239a47a..9aa7955d5d31 100644 > --- a/drivers/net/ethernet/broadcom/tg3.c > +++ b/drivers/net/ethernet/broadcom/tg3.c > @@ -2123,15 +2123,13 @@ static int tg3_phy_init(struct tg3 *tp) > case PHY_INTERFACE_MODE_RGMII: > if (!(tp->phy_flags & TG3_PHYFLG_10_100_ONLY)) { > phy_set_max_speed(phydev, SPEED_1000); > - phydev->supported |= (SUPPORTED_Pause | > - SUPPORTED_Asym_Pause); > + phy_support_asym_pause(phydev); > break; > } > /* fallthru */ > case PHY_INTERFACE_MODE_MII: > phy_set_max_speed(phydev, SPEED_100); > - phydev->supported |= (SUPPORTED_Pause | > - SUPPORTED_Asym_Pause); > + phy_support_asym_pause(phydev); Your indentation is off by a tab here. -- Florian