From: "Sverdlin, Alexander" <alexander.sverdlin@siemens.com>
To: "olteanv@gmail.com" <olteanv@gmail.com>
Cc: "agust@denx.de" <agust@denx.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"andrew@lunn.ch" <andrew@lunn.ch>
Subject: Re: [PATCH net v2] net: dsa: lan9303: ensure chip reset and wait for READY status
Date: Fri, 4 Oct 2024 07:26:21 +0000 [thread overview]
Message-ID: <b4e0dba3867bc16f6c0a26f2767e559d5a4156fe.camel@siemens.com> (raw)
In-Reply-To: <20241003211524.ugrkjjc7legax2ak@skbuf>
Thanks for the review Vladimir!
On Fri, 2024-10-04 at 00:15 +0300, Vladimir Oltean wrote:
> > + * switch's reading of EEPROM right after reset and this behaviour is
> > + * not configurable. While lan9303_read() already has quite long retry
> > + * timeout, seems not all cases are being detected as arbitration error.
>
> These arbitration errors happen only after reset? So in theory, after
> this patch, we could remove the for() loop from lan9303_read()?
This is a good point! Shall I add the removal to a series for net or post the
removal separately for net-next?
--
Alexander Sverdlin
Siemens AG
www.siemens.com
next prev parent reply other threads:[~2024-10-04 7:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 17:12 [PATCH net v2] net: dsa: lan9303: ensure chip reset and wait for READY status A. Sverdlin
2024-10-03 21:15 ` Vladimir Oltean
2024-10-04 7:26 ` Sverdlin, Alexander [this message]
2024-10-04 8:16 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4e0dba3867bc16f6c0a26f2767e559d5a4156fe.camel@siemens.com \
--to=alexander.sverdlin@siemens.com \
--cc=agust@denx.de \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).