From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFA8CC43381 for ; Wed, 13 Feb 2019 21:38:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1F51222A4 for ; Wed, 13 Feb 2019 21:38:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TkBaatE5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394911AbfBMVia (ORCPT ); Wed, 13 Feb 2019 16:38:30 -0500 Received: from mail-yw1-f67.google.com ([209.85.161.67]:36994 "EHLO mail-yw1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731177AbfBMVia (ORCPT ); Wed, 13 Feb 2019 16:38:30 -0500 Received: by mail-yw1-f67.google.com with SMTP id k14so1507610ywe.4; Wed, 13 Feb 2019 13:38:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BQKJ7AGHiqWFy46aDaZLMvhQGtlMQh3fbIw0PqcyTY4=; b=TkBaatE53mgkvwWvzYPNYdDVqAm7u32Vo69kDHhRtb+/7tTpceMtUFzhZB5DDecqRx HCKT65jBiYdDzSObSpACR8UQRLZ/ypvX0y+2gQD1u0StFt/aYFCIeHL2x5uKsWDs48ry KfTHmXaj56zBCYoSPdBhAG6meb6hgjhKDCRE3MMqHsBGCTezrQ2gKgZ8YbTZRv/ZVQFO /sM3k6NLl3NArkfh0mi7IsF4oF0RLJ6to4HlT/+maylKUhhNPLgZx7l5OSXgcuQOqGrj 7bw+JeRMsgI7jCVIP1NPrrnal73O0tLpDzAtLduEECT2jIjIdB2d2ZmnWUbmHumnkxTR 1wRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=BQKJ7AGHiqWFy46aDaZLMvhQGtlMQh3fbIw0PqcyTY4=; b=pJIv3sLmRGIb1ukaVfuVo8R6F8MJG+4expY+zUTdI9HGLzzx+4azzvb74s3XSF/S2z I2M5nys7um3cqLE6A6+gcHr/b7pYDeXTcOUPHRLn4rXOTiJp6LIQf6FdO7aVGZ8oViQm xrc93zbjkvWRoN08a6qm9bkwoOQfuCMDjaaEeXxvrA4Gz9ymGDoYGRfb/P6HUou2gIXe pWEBukAPD5oRDdFrIUZe+o+KnY4bPAJ8NH+RbUh697QT98n3QcFLaIESH0wJAX3tIKjP CUe4t8tOgQx7f09ijoLp25sduDIEGoxypUrsvFb7fn3o02VR8mihjrW+JhLEeuli4cgp E2Cw== X-Gm-Message-State: AHQUAuYVDgUEDLoSr0E9yJZpH4cE2VLNYtQqXPgJiGSAHrg2zEUw2xxk 1YjofxxyvQH8H20Xv1yggqg= X-Google-Smtp-Source: AHgI3IaglAghLp24oEMCpKayaRzw45fNbotisjqDl50TnuE2lleSwJlLaZ/I1W+/zMMpZQH2aS1ZKQ== X-Received: by 2002:a81:5f06:: with SMTP id t6mr274834ywb.28.1550093908516; Wed, 13 Feb 2019 13:38:28 -0800 (PST) Received: from [10.67.48.220] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id x70sm148024ywg.16.2019.02.13.13.38.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 13:38:27 -0800 (PST) Subject: Re: [PATCH] net: phy: at803x: disable delay only for RGMII mode To: Niklas Cassel Cc: Marc Gonzalez , Andrew Lunn , Vinod Koul , David S Miller , linux-arm-msm@vger.kernel.org, Bjorn Andersson , netdev@vger.kernel.org, "Nori, Sekhar" , Peter Ujfalusi , hkallweit1@gmail.com References: <20190212141922.12849-1-vkoul@kernel.org> <20190213131206.GA460@centauri.lan> <20190213132900.GA24589@lunn.ch> <1ab5edac-a36c-9dc5-52e5-dbd3b70e7728@free.fr> <20190213174034.GA6954@centauri.lan> <34037b72-b082-89fa-f586-8c032ebe5aea@gmail.com> <20190213200738.GB460@centauri.lan> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: Date: Wed, 13 Feb 2019 13:38:16 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190213200738.GB460@centauri.lan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/13/19 12:07 PM, Niklas Cassel wrote: > On Wed, Feb 13, 2019 at 09:59:43AM -0800, Florian Fainelli wrote: >> On 2/13/19 9:40 AM, Niklas Cassel wrote: >>> On Wed, Feb 13, 2019 at 02:40:18PM +0100, Marc Gonzalez wrote: >>>> On 13/02/2019 14:29, Andrew Lunn wrote: >>>> >>>>>> So we have these modes: >>>>>> >>>>>> PHY_INTERFACE_MODE_RGMII: TX and RX delays disabled >>>>>> PHY_INTERFACE_MODE_RGMII_ID: TX and RX delays enabled >>>>>> PHY_INTERFACE_MODE_RGMII_RXID: RX delay enabled, TX delay disabled >>>>>> PHY_INTERFACE_MODE_RGMII_TXID: TX delay enabled, RX delay disabled >>>>>> >>>>>> What I don't like with this patch, is that if we specify phy-mode >>>>>> PHY_INTERFACE_MODE_RGMII_TXID, this patch will enable TX delay, >>>>>> but RX delay will not be explicitly set. >>>>> >>>>> That is not the behaviour we want. It is best to assume the device is >>>>> in a random state, and correctly enable/disable all delays as >>>>> requested. Only leave the hardware alone if PHY_INTERFACE_MODE_NA is >>>>> used. >>>> >>>> That's what my patch did: >>>> https://www.spinics.net/lists/netdev/msg445053.html >>>> >>>> But see Florian's remarks: >>>> https://www.spinics.net/lists/netdev/msg445133.html >>> >>> Hello Marc, >>> >>> I saw that comment from Florian. However that was way back in 2017. >>> Maybe the phy-modes were not as well defined back then? >> >> The definition of the 'phy-mode' was clarified to be understood from the >> perspective of the PHY device (hence the name) after we had several >> fruitful exchanges with Marc (at least from my perspective), but since >> the definition was not clear before, there is a high chance of finding >> DTS/DTBs out there with the 'phy-mode' property understood from the >> MAC's perspective, which would now be wrong. > > Hello Florian, > > > We have a specification: > Documentation/devicetree/bindings/net/ethernet.txt > > And several implementations: the PHY drivers. > > Either we decide that all PHY drivers have to follow > the specification for "phy-mode" in > Documentation/devicetree/bindings/net/ethernet.txt > or we decide that they don't. > > If we decide that all PHY drivers have to follow the specification, > then we can fix the PHY drivers that currently do not follow the > specification. > > If we decide that all PHY drivers do not have to follow the spec, > then the "phy-mode" property is basically useless, and then we should > introduce a new device tree property, e.g. "phy-mode2", that is > guaranteed to respect the definitons in > Documentation/devicetree/bindings/net/ethernet.txt If the specification had been clear from day one, then we would not be in the situation we are in today, so in that case it is not as simple as: a) deprecating an existing property that was misused because the spec was not well enough defined and b) go and fix all drivers. The amount of breakage that can be introduced is just immense, and quite frankly, for absolutely no good reason. It's all well and good to introduce a 'phy-mode2' but let's think about the future: - what is depreciation path for 'phy-mode'/'phy-connection-type' looking like then? - do we have the manpower to review every new binding, DTS submission that gets included in Linux, FreeBSD, Zephyr, for correctness? > >> >> >>> >>> Andrew recently suggested to fix the driver so that it conforms with the >>> phy-modes, and fix any SoC that specified an incorrect phy-mode in DT >>> and thus relied upon the broken behavior of the PHY driver: >>> https://www.spinics.net/lists/netdev/msg445133.html >>> >>> >>> So, I've rebased your old patch, see attachment. >>> I suggest that Peter test it on am335x-evm. >>> >>> am335x-evm appears to rely on the current broken behavior of the PHY >>> driver, so we will probably need to fix the am335x-evm according to this: >>> https://www.spinics.net/lists/netdev/msg445117.html >>> and merge that as well. >>> >>> >>> Andrew, Florian, do you both agree? >> >> In my reply to Marc, there was a concern that while am335x-evm was >> identified and reported to be broken after fixing the PHY driver, there >> could be platforms out there that we have little to no visibility that >> would most likely be equally broken. That concern still exists, and I >> don't think there is anything we can do to even assess the size of the >> problem unless we attempt to fix it, so maybe we should attempt to fix that. >> >> There was a suggestion to Marc that one way to possibly "ignore" an >> incorrectly broken 'phy-mode' property would be to allow specifying >> rx/tx delay properties such that if the driver obtained its >> phy_interface_t, yet still parsed rx/tx delays, the rx/tx delays would >> take precedence, and we could possibly derive some sort of a "more >> correct" phy_interface_t that we could assign back to phydev->interface >> and issue a warning about that. > > You mean to add new device tree properties to > Documentation/devicetree/bindings/net/ethernet.txt > > - phy-id-tx: "true" if PHY should add internal delay on TX lines; > "false" or not specified if PHY should not add internal > delay on TX lines. This property overrides any delay > requested by "phy-mode". > - phy-id-rx: "true" if PHY should add internal delay on RX lines; > "false" or not specified if PHY should not add internal > delay on RX lines. This property overrides any delay > requested by "phy-mode". > > Perhaps something like that? Not quite booleans, actual delay values, e.g.: tx-delay-ps = <2000> rx-delay-ps = <2000> this is something that exists already: Documentation/devicetree/bindings/net/apm-xgene-enet.txt Documentation/devicetree/bindings/net/cavium-pip.txt Documentation/devicetree/bindings/net/dwmac-sun8i.txt because conceptually, telling the PHY driver that a TX or RX delay is simply not enough, sometimes the standard 2ns (90 degree shift at 125Mhz) is not good enough and gets you out of spec because of some board design. > > Personally, I prefer making "phy-mode" strict, > but whatever you guys decide: > - making "phy-mode" strict > - introducing a "phy-mode2" > - introducing "phy-id-tx/phy-id-rx" > - introducing "mac-mode" > - some other solution > > It is probably wise to introduce helper functions in phy.h > phy_wants_id_rx() > phy_wants_id_tx() > so that PHY drivers can simply use e.g.: > > if (phy_wants_id_rx(phydev)) > at803x_enable_rx_delay(phydev); > else > at803x_disable_rx_delay(phydev); > > if (phy_wants_id_tx(phydev)) > at803x_enable_tx_delay(phydev); > else > at803x_disable_tx_delay(phydev); Yes, that I think is pretty much orthogonal to the end solution we decide to choose, having a way to tell what the PHY is currently configured, or capable of supporting is step 1 in trying to find a compatibility solution. > >> >> Another possible way to resolve that could be to introduce a 'mac-mode' >> property, which must be strictly compatible with specifying a 'phy-mode' >> property. For instance: >> >> - MAC specifies mac-mode = 'rgmii-id', then the PHY must have phy-mode = >> 'rmgii' since the MAC is taking of inserting both RX and TX delays, >> reverse also applies >> >> - MAC specifies mac-mode = 'rgmii-txid', then the PHY must have phy-mode >> = 'rgmii-rxid' because the MAC adds the TX delay, but the PHY should >> insert the delay on the RX lines, reverse also applies >> >> Because there is usually (not always, DSA is an exception) a 1:1 mapping >> between MAC and PHY devices we could look up the 'mac-mode' property in >> the MAC in the PHY library code and make sure that we have a compatible >> matrix and if we do not, maybe pass something like PHY_INTERFACE_MODE_NA >> such that the driver retains its settings. > > Is there any advantage of creating a "mac-mode" over creating a > "phy-mode2" ? > > > Kind regards, > Niklas > >> >> Maybe another way to approach this is if we assume that the PHY comes up >> configured correctly by the boot loader, or upon power on reset, we add >> some PHY driver methods that allow us to determine the RGMII mode in >> which a PHY is and that tells us whether we are compatible with the >> MAC's phy_interface_t upon connection. We check both at connect() time >> and if something does not look right, we flip the meaning of >> phy_interface_t. >> >> None of those solutions are entirely fool proof, but at least we might >> be able to detect incorrect combinations, yet still make them work by >> reversing the meaning of the 'phy-mode' property given information at hand. >> >> Let me know if none of that makes sense and this just looks like yet >> another brain dump. >> >> Wonderful RGMII... >> -- >> Florian -- Florian