From: David Ahern <dsahern@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>, netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] macvlan: Add bclim parameter
Date: Wed, 29 Mar 2023 08:51:50 -0600 [thread overview]
Message-ID: <b52bb122-b5e2-cff1-1c0a-ad8a855e278d@gmail.com> (raw)
In-Reply-To: <ZCJYxDy1fgCm+cbj@gondor.apana.org.au>
On 3/27/23 9:02 PM, Herbert Xu wrote:
> @@ -67,6 +68,12 @@ static int bc_queue_len_arg(const char *arg)
> return -1;
> }
>
> +static int bclim_arg(const char *arg)
> +{
> + fprintf(stderr, "Error: illegal value for \"bclen\": \"%s\"\n", arg);
s/bclen/bclim/?
> + return -1;
> +}
> +
> static int macvlan_parse_opt(struct link_util *lu, int argc, char **argv,
> struct nlmsghdr *n)
> {
> @@ -168,6 +175,15 @@ static int macvlan_parse_opt(struct link_util *lu, int argc, char **argv,
> return bc_queue_len_arg(*argv);
> }
> addattr32(n, 1024, IFLA_MACVLAN_BC_QUEUE_LEN, bc_queue_len);
> + } else if (matches(*argv, "bclim") == 0) {
we stopped accepting new uses of `matches`; make this strcmp.
next prev parent reply other threads:[~2023-03-29 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 2:56 [PATCH 0/2] macvlan: Allow some packets to bypass broadcast queue Herbert Xu
2023-03-28 2:57 ` [PATCH 1/2] macvlan: Skip broadcast queue if multicast with single receiver Herbert Xu
2023-03-28 2:57 ` [PATCH 2/2] macvlan: Add netlink attribute for broadcast cutoff Herbert Xu
2023-03-28 3:02 ` [PATCH iproute2-next] macvlan: Add bclim parameter Herbert Xu
2023-03-29 14:51 ` David Ahern [this message]
2023-03-30 3:07 ` [v2 PATCH " Herbert Xu
2023-03-30 16:01 ` David Ahern
2023-03-29 8:10 ` [PATCH 0/2] macvlan: Allow some packets to bypass broadcast queue patchwork-bot+netdevbpf
2023-03-29 8:45 ` [PATCH] macvlan: Fix mc_filter calculation Herbert Xu
2023-03-31 8:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b52bb122-b5e2-cff1-1c0a-ad8a855e278d@gmail.com \
--to=dsahern@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).