From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80310204F73 for ; Thu, 10 Oct 2024 08:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728547421; cv=none; b=co9Jpz7B1aeERsvHPAjdmuwhS0LMHiUii8IIWZEdd87unJXenHvJZcK2rAy2GWp73+RZaUUubl+5rJYe2EgxG9+S3cCMMPbrgdrJ9TVorUsXXpC5EtLAZ14vP/nQWCiUKcGN+zl2/cudJqmNB5YT5xieAPNCGEoUYjFeb+QcX+8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728547421; c=relaxed/simple; bh=o6Yj13wTDdGSHGjmO/sKiO7EHFlnxmZYRbSplb6dOKU=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=iubMRhT7aujjqdy8XmfnRAcbIlxfIDbxWB4AcPY240guLl0qD8hnQj18Lmb3tXZdUWBx62MsGLqLSm+HMunae5QEfemRk7or0TGP0N0j1RH1XE9bQt3n3EWViN4nBCm6UjHVpwo1Ef5x7fcRzGwcrF48TtOmyYnYbbDdI4Koxt0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ky3II9Pe; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ky3II9Pe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728547418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o6Yj13wTDdGSHGjmO/sKiO7EHFlnxmZYRbSplb6dOKU=; b=Ky3II9Pe3t+C8sy+q5JqGqtM4N6q9hBTKb3fJQlgpGWMAjh/9cw+QGUXkpPqBg1rpTBzT8 V4UmNt3nnLLogexCYPieKb+IRFQhRRogi+ShxZMy9j5iU2XQht2xYDAkOysu8eD3CrUejR B7Q/maoBGW7UXO+VSgfbhrm788fJ/ZA= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-499-EME7bqCtNZezkhn-1bkOig-1; Thu, 10 Oct 2024 04:03:37 -0400 X-MC-Unique: EME7bqCtNZezkhn-1bkOig-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-37d3986f5a4so185862f8f.3 for ; Thu, 10 Oct 2024 01:03:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728547415; x=1729152215; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=o6Yj13wTDdGSHGjmO/sKiO7EHFlnxmZYRbSplb6dOKU=; b=RcS9Bve7XtveHsyTBr8fQnupoS9QOkJhixjbhbEuIPph2au7Poi/amfVolzSZiGLe/ 2HN0jPR3Z82HFV6fXqX3eqDDgPU7AIFgJkFN0UGH5k99o0rfhUyDYxPnPKxPj3/DTq8A f/g3gnTzhSuT6pfquVyRfQ7neCp09Ru1B5O8eOEYzUunwdxBUYP4x3CUsNzrLS2ZorQN LgYxV6SFSkTqvW/bDZpDP+XiSfO86MA0SoAWdrUcwEEupCRgPdF0S+uEa+P0BWZGIWY9 4d1UtPAr1QnMDbHbMfmvRX6PODFX1uhbD/2xk8G/s+2QrT296IbAv95eZwVAQrQ/osmx gZ7w== X-Forwarded-Encrypted: i=1; AJvYcCUzLXk1PyoNAO3tQxSJTMg3RS9785LJQTjMx03nTRnc4lFjk8VfsoqPcBNLeaqUW1NMXa1Qj5A=@vger.kernel.org X-Gm-Message-State: AOJu0YxNRBpiOghyPr6p1Gh/4KN6zw70b8RmTz1j1zYvD14Upb5FEl57 GqaofLvD8ldVZAbFsbifBSENdWzJpew66XVGU6/kL7poTtQa18xNoxps1wlqXp79Xj/VKLB+Ssw VV0yQoVu4CxwaVE2s6xaVRjS3HTfkc3OOcLqiT2PxIbEc6FHzqu/ZRg== X-Received: by 2002:adf:f3c7:0:b0:37c:d299:b5f0 with SMTP id ffacd0b85a97d-37d3ab44f04mr2752602f8f.59.1728547414855; Thu, 10 Oct 2024 01:03:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFCPZ/N+8I6yvkHpm2WH4x1aWbcKYPe3oMumoEtWLk5b9nz8TmEseUc5OhVu0HO7+xCgvRnQw== X-Received: by 2002:adf:f3c7:0:b0:37c:d299:b5f0 with SMTP id ffacd0b85a97d-37d3ab44f04mr2752523f8f.59.1728547414296; Thu, 10 Oct 2024 01:03:34 -0700 (PDT) Received: from dhcp-64-16.muc.redhat.com (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b7edecasm776544f8f.97.2024.10.10.01.03.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Oct 2024 01:03:33 -0700 (PDT) Message-ID: Subject: Re: [RFC PATCH 10/13] staging: rts5280: Use always-managed version of pci_intx() From: Philipp Stanner To: Philipp Hortmann , Greg Kroah-Hartman Cc: Damien Le Moal , Niklas Cassel , Sergey Shtylyov , Basavaraj Natikar , Jiri Kosina , Benjamin Tissoires , Arnd Bergmann , Alex Dubov , Sudarsana Kalluru , Manish Chopra , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rasesh Mody , GR-Linux-NIC-Dev@marvell.com, Igor Mitsyanko , Sergey Matyukevich , Kalle Valo , Sanjay R Mehta , Shyam Sundar S K , Jon Mason , Dave Jiang , Allen Hubbe , Bjorn Helgaas , Alex Williamson , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Jaroslav Kysela , Takashi Iwai , Mario Limonciello , Chen Ni , Ricky Wu , Al Viro , Breno Leitao , Kevin Tian , Thomas Gleixner , Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , Mostafa Saleh , Andy Shevchenko , Hannes Reinecke , John Garry , Soumya Negi , Jason Gunthorpe , Yi Liu , "Dr. David Alan Gilbert" , Christian Brauner , Ankit Agrawal , Reinette Chatre , Eric Auger , Ye Bin , Marek =?ISO-8859-1?Q?Marczykowski-G=F3recki?= , Pierre-Louis Bossart , Maarten Lankhorst , Kai Vehmanen , Peter Ujfalusi , Rui Salvaterra , Marc Zyngier , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ntb@lists.linux.dev, linux-pci@vger.kernel.org, linux-staging@lists.linux.dev, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-sound@vger.kernel.org Date: Thu, 10 Oct 2024 10:03:30 +0200 In-Reply-To: <411f3c94-58b5-471e-bc58-e23d89d2078f@gmail.com> References: <20241009083519.10088-1-pstanner@redhat.com> <20241009083519.10088-11-pstanner@redhat.com> <2024100936-brunette-flannels-0d82@gregkh> <411f3c94-58b5-471e-bc58-e23d89d2078f@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2024-10-09 at 21:41 +0200, Philipp Hortmann wrote: > On 10/9/24 11:38, Greg Kroah-Hartman wrote: > > On Wed, Oct 09, 2024 at 10:35:16AM +0200, Philipp Stanner wrote: > > > pci_intx() is a hybrid function which can sometimes be managed > > > through > > > devres. To remove this hybrid nature from pci_intx(), it is > > > necessary to > > > port users to either an always-managed or a never-managed > > > version. > > >=20 > > > rts5208 enables its PCI-Device with pcim_enable_device(). Thus, > > > it needs the > > > always-managed version. > > >=20 > > > Replace pci_intx() with pcim_intx(). > > >=20 > > > Signed-off-by: Philipp Stanner > > > --- > > > =C2=A0 drivers/staging/rts5208/rtsx.c | 2 +- > > > =C2=A0 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > Acked-by: Greg Kroah-Hartman > >=20 >=20 > Hi Philipp, >=20 > this driver (rts5208) will be removed soon - patch is send in. >=20 > Discussion about removal: > https://lore.kernel.org/linux-staging/2024100943-shank-washed-a765@gregkh= /T/#t Alright, thx for the heads up. I'm not entirely how best to deal with that, though. I could drop this patch, but then the driver would end up with an unmanaged pci_intx(). Might this be a problem for users if my series lands sooner than the removal, say in v6.13 and your removal in v6.14? P. >=20 > Thanks for your support. >=20 > Bye Philipp >=20