From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A9E52AE8D for ; Mon, 8 Jun 2026 15:48:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780933701; cv=none; b=uJtMw5UtdwQvFrYvulFhVYjQRiSy7YzaNrAi7J/7lIZw83J8CPvfSUh0OhUxULvtTZqTAWtj25+KOSwrbpbCqvpLKwm3k83EnTSxNXhFSmvILf1RLjdwjOaSvG5byVzip+n04WpF/Phn/mJ0tOCNWsyEF1MpGb2G84/3DrEUKOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780933701; c=relaxed/simple; bh=gXWiAR3eG1hw3O6lLoirp5wSX06NvOORpD7MunpI880=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Uz7GuSEa5OPbu5fj2KFf5mf+A7c82YSJNWMPUKFqL9KuHaQpJIPCe7yKdLHuBegXHCDvwFBTxN8+4xrFSTb8sgv5ZZJn2PIFoDupQVdZOkGlSoTwuAGOX9J/DLPh1634lzmQRR2Zg+cEF1Ve9Aga2GolQAKSnHidgm4TJ/XTQFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Kfzda56T; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Kfzda56T" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780933699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iQZZjnNUgN0/UHamiYqEX7QtlS2rp32rDzK8Diz0cFA=; b=Kfzda56Tw2UZJZoeFHRo8cjg+PblLXkWAvqFawo3Mvc4uRJ3ZidWofUhxVHMyOxFUVJnGj kB9eYu0AtyitThiuUfvaPh8jensN+9GZyrnRiMaTQ5bdG2G7qM/RDF/5shqzbLOj5WjqyT smUHJXFfZ9lVYHZ802UNor9Lxvrruhk= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-lxBG658nMNS8ALq4SlugEQ-1; Mon, 08 Jun 2026 11:48:14 -0400 X-MC-Unique: lxBG658nMNS8ALq4SlugEQ-1 X-Mimecast-MFC-AGG-ID: lxBG658nMNS8ALq4SlugEQ_1780933693 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7FCC1180075E; Mon, 8 Jun 2026 15:48:12 +0000 (UTC) Received: from [10.44.32.246] (unknown [10.44.32.246]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 60DF31800370; Mon, 8 Jun 2026 15:48:08 +0000 (UTC) Message-ID: Date: Mon, 8 Jun 2026 17:48:06 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 1/4] dpll: add DPLL_PIN_TYPE_INT_NCO pin type To: "Kubalewski, Arkadiusz" , "netdev@vger.kernel.org" Cc: Jiri Pirko , "David S. Miller" , Donald Hunter , Eric Dumazet , Jakub Kicinski , Jiri Pirko , "Schmidt, Michal" , Paolo Abeni , "Vaananen, Pasi" , "Oros, Petr" , Prathosh Satish , Simon Horman , Vadim Fedorenko , "linux-kernel@vger.kernel.org" References: <20260531194423.383366-1-ivecera@redhat.com> <20260531194423.383366-2-ivecera@redhat.com> Content-Language: en-US From: Ivan Vecera In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On 6/8/26 4:43 PM, Kubalewski, Arkadiusz wrote: >> From: Ivan Vecera >> Sent: Sunday, May 31, 2026 9:44 PM >> ... >> - >> name: gnss >> doc: GNSS recovered clock >> + - >> + name: int-nco >> + doc: | >> + Device internal numerically controlled oscillator. >> + When connected as a DPLL input, the DPLL enters NCO mode >> + where the output frequency is adjusted by the host via >> + the PTP clock interface. > > Hi Ivan! > > How would you control this in case of automatic mode dpll? > Automatic mode DPLL shall be controlled on HW level, such pin brakes > that rule and requires some driver magic to show it is higher > priority then the rest of the pins? The NCO pin can be connected only in manual mode. In other words a DPLL in automatic mode cannot select NCO pin (switch to NCO mode) by its own. If the DPLL device is in automatic mode then a user has to switch the device to manual mode and then manually set the NCO pin as connected. > Such NCO mode/pin is designed only for this single specific use case > where a timecard contains a DPLL and PHC? This is designed for a HW where DPLL channels (devices) support ToD counters (can act as PHC besides DPLL functionality) and support the mode where DPLL is not locked to any physical input and allows tuning of its frequency. > Any diagram? > > Is there any other use case for such pin? (NCO is rather a general > DPLL control mechanism?) Shouldn't it be called explicitly like > ptp-nco? I discussed this with Jiri and result was: - DPLL_MODE is input selection strategy - NCO is a case of manual selection strategy And *_INT_PTP_NCO or *_PTP_NCO? Yes, this could be reasonable... I can't think of anything else to use other than PTP... for now (can be changed in future). Thanks, Ivan