From: Hannes Eder <heder@google.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, lvs-users@linuxvirtualserver.org,
malcolm@loadbalancer.org, linux-kernel@vger.kernel.org,
David Miller <davem@davemloft.net>,
Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH] IPVS: logging sizeof(struct ip_vs_conn) on startup
Date: Mon, 27 Jul 2009 12:34:42 +0200 [thread overview]
Message-ID: <b5ddba180907270334m4bc4e968m85c16ea4756c3f5d@mail.gmail.com> (raw)
In-Reply-To: <4A6D7285.9080909@gmail.com>
On Mon, Jul 27, 2009 at 11:25, Eric Dumazet<eric.dumazet@gmail.com> wrote:
> Well, ip_vs_conn_cache uses SLAB_HWCACHE_ALIGN, so this should be rounded up
> to L1 cache size. Or add "at least" like in line 1080
> of net/netfilter/ipvs/ip_vs_conn.c :
>
> IP_VS_DBG(0, "Each connection entry needs %Zd bytes at least\n",
> sizeof(struct ip_vs_conn));
Good point. Is there an easy way to figure out how much memory is
wasted for alignment by the slab allocator? Otherwise I vote for the
"at least" approach.
-Hannes
next prev parent reply other threads:[~2009-07-27 10:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 9:08 [PATCH] IPVS: logging sizeof(struct ip_vs_conn) on startup Hannes Eder
2009-07-27 9:22 ` Simon Horman
2009-07-27 9:25 ` Eric Dumazet
2009-07-27 10:34 ` Hannes Eder [this message]
2009-07-27 13:13 ` [PATCH v2] " Hannes Eder
2009-07-27 18:48 ` David Miller
2009-07-28 0:19 ` Simon Horman
2009-07-28 5:38 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5ddba180907270334m4bc4e968m85c16ea4756c3f5d@mail.gmail.com \
--to=heder@google.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-users@linuxvirtualserver.org \
--cc=malcolm@loadbalancer.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).