From: Hannes Eder <heder@google.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Wensong Zhang <wensong@linux-vs.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH] ipvs: Add boundary check on ioctl arguments
Date: Wed, 30 Sep 2009 17:33:01 +0200 [thread overview]
Message-ID: <b5ddba180909300833g2b1fd22ak3e094e10fe10e8a@mail.gmail.com> (raw)
In-Reply-To: <20090930171833.5ce0011d@infradead.org>
On Wed, Sep 30, 2009 at 17:18, Arjan van de Ven <arjan@infradead.org> wrote:
> On Wed, 30 Sep 2009 15:38:12 +0200
> Hannes Eder <heder@google.com> wrote:
>> > @@ -2353,17 +2357,25 @@ do_ip_vs_get_ctl(struct sock *sk, int cmd,
>> > void __user
>> *user, int *len)
>> > {
>> > unsigned char arg[128];
>>
>> can MAX_ARG_LEN be used here?
>
> I am not convinced... it is a different numerical value,
> so it could be an ABI change. Rather not do that in this
> type of patch...
For do_ip_vs_set_ctl MAX_ARG_LEN is used:
static int
do_ip_vs_set_ctl(struct sock *sk, int cmd, void __user *user, unsigned int len)
{
int ret;
unsigned char arg[MAX_ARG_LEN];
...
I assume that will be fine for do_ip_vs_get_ctl as well.
-Hannes
next prev parent reply other threads:[~2009-09-30 15:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 11:11 [PATCH] ipvs: Add boundary check on ioctl arguments Arjan van de Ven
2009-09-30 13:38 ` Hannes Eder
2009-09-30 15:18 ` Arjan van de Ven
2009-09-30 15:33 ` Hannes Eder [this message]
2009-09-30 19:41 ` Julian Anastasov
2009-10-01 7:22 ` Arjan van de Ven
2009-10-02 8:35 ` Julian Anastasov
2009-12-15 6:17 ` Arjan van de Ven
2009-12-15 6:32 ` Simon Horman
2009-12-24 4:16 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2009-12-29 1:58 Simon Horman
2010-01-04 13:59 ` Patrick McHardy
2010-01-04 15:34 ` Arjan van de Ven
2010-01-04 15:39 ` Patrick McHardy
2010-01-04 23:25 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5ddba180909300833g2b1fd22ak3e094e10fe10e8a@mail.gmail.com \
--to=heder@google.com \
--cc=arjan@infradead.org \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).