netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Victor Nogueira <victor@mojatatu.com>
To: Alexandre Ferrieux <alexandre.ferrieux@gmail.com>, edumazet@google.com
Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
	horms@kernel.org, alexandre.ferrieux@orange.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH net v7] net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes.
Date: Sun, 10 Nov 2024 15:14:08 -0300	[thread overview]
Message-ID: <b5df8fb4-e093-4798-8644-fd0604d0d7fe@mojatatu.com> (raw)
In-Reply-To: <20241110172836.331319-1-alexandre.ferrieux@orange.com>

On 10/11/2024 14:28, Alexandre Ferrieux wrote:
> To generate hnode handles (in gen_new_htid()), u32 uses IDR and
> encodes the returned small integer into a structured 32-bit
> word. Unfortunately, at disposal time, the needed decoding
> is not done. As a result, idr_remove() fails, and the IDR
> fills up. Since its size is 2048, the following script ends up
> with "Filter already exists":
> 
>    tc filter add dev myve $FILTER1
>    tc filter add dev myve $FILTER2
>    for i in {1..2048}
>    do
>      echo $i
>      tc filter del dev myve $FILTER2
>      tc filter add dev myve $FILTER2
>    done
> 
> This patch adds the missing decoding logic for handles that
> deserve it.
> 
> Fixes: e7614370d6f0 ("net_sched: use idr to allocate u32 filter handles")
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Alexandre Ferrieux <alexandre.ferrieux@orange.com>

Tested-by: Victor Nogueira <victor@mojatatu.com>

  reply	other threads:[~2024-11-10 18:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-10 17:28 [PATCH net v7] net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes Alexandre Ferrieux
2024-11-10 18:14 ` Victor Nogueira [this message]
2024-11-13  5:00 ` patchwork-bot+netdevbpf
2024-11-14 18:24   ` RFC: chasing all idr_remove() misses Alexandre Ferrieux
2024-11-19  3:51     ` Cong Wang
2024-11-19  3:57       ` Cong Wang
2024-11-19  6:46       ` Alexandre Ferrieux
2024-11-22 21:32         ` Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5df8fb4-e093-4798-8644-fd0604d0d7fe@mojatatu.com \
    --to=victor@mojatatu.com \
    --cc=alexandre.ferrieux@gmail.com \
    --cc=alexandre.ferrieux@orange.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).