From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA926C433EF for ; Wed, 19 Jan 2022 10:56:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353553AbiASK4Z (ORCPT ); Wed, 19 Jan 2022 05:56:25 -0500 Received: from mxout04.lancloud.ru ([45.84.86.114]:57474 "EHLO mxout04.lancloud.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240254AbiASK4V (ORCPT ); Wed, 19 Jan 2022 05:56:21 -0500 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout04.lancloud.ru A771820D27E6 Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH 1/2] platform: make platform_get_irq_optional() optional (summary) To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "Greg Kroah-Hartman" CC: Andrew Lunn , Ulf Hansson , Vignesh Raghavendra , , "Rafael J. Wysocki" , , Linus Walleij , Amit Kucheria , , Liam Girdwood , "Guenter Roeck" , Thierry Reding , , , Miquel Raynal , , Lee Jones , Khuong Dinh , "Florian Fainelli" , Matthias Schiffer , Joakim Zhang , Kamal Dasu , Jiri Slaby , "Bartosz Golaszewski" , Daniel Lezcano , "Tony Luck" , Kishon Vijay Abraham I , , , Jakub Kicinski , Zhang Rui , "Matthias Brugger" , , , Robert Richter , "Saravanan Sekar" , Corey Minyard , , Mauro Carvalho Chehab , "John Garry" , Peter Korsgaard , "William Breathitt Gray" , Mark Gross , , Alex Williamson , Mark Brown , Borislav Petkov , Eric Auger , Takashi Iwai , Jaroslav Kysela , , Andy Shevchenko , Benson Leung , Pengutronix Kernel Team , , , "Richard Weinberger" , Mun Yew Tham , "Hans de Goede" , , Yoshihiro Shimoda , Cornelia Huck , , , , , Vinod Koul , James Morse , Zha Qipeng , Sebastian Reichel , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , , Brian Norris , "David S. Miller" References: <20220110195449.12448-1-s.shtylyov@omp.ru> <20220110195449.12448-2-s.shtylyov@omp.ru> <20220115183643.6zxalxqxrhkfgdfq@pengutronix.de> <20220118091819.zzxpffrxbckoxiys@pengutronix.de> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Wed, 19 Jan 2022 13:56:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220118091819.zzxpffrxbckoxiys@pengutronix.de> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/18/22 12:18 PM, Uwe Kleine-König wrote: > On Sun, Jan 16, 2022 at 03:19:06PM +0100, Greg Kroah-Hartman wrote: >> On Sat, Jan 15, 2022 at 07:36:43PM +0100, Uwe Kleine-König wrote: >>> A possible compromise: We can have both. We rename >>> platform_get_irq_optional() to platform_get_irq_silent() (or >>> platform_get_irq_silently() if this is preferred) and once all users are >>> are changed (which can be done mechanically), we reintroduce a >>> platform_get_irq_optional() with Sergey's suggested semantic (i.e. >>> return 0 on not-found, no error message printking). >> >> Please do not do that as anyone trying to forward-port an old driver >> will miss the abi change of functionality and get confused. Make >> build-breaking changes, if the way a function currently works is >> changed in order to give people a chance. > > Fine for me. I assume this is a Nack for Sergey's patch? Which patch do you mean? I'm starting to get really muddled... :-( > Best regards > Uwe MBR, Sergey