From: Florian Fainelli <florian.fainelli@broadcom.com>
To: justin.chen@broadcom.com, netdev@vger.kernel.org
Cc: bcm-kernel-feedback-list@broadcom.com, horms@kernel.org,
pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, andrew+netdev@lunn.ch
Subject: Re: [PATCH net v2 2/2] net: bcmasp: fix double disable of clk
Date: Mon, 16 Mar 2026 12:14:52 -0700 [thread overview]
Message-ID: <b63ed1da-ea55-49a7-8e25-03f85535d51c@broadcom.com> (raw)
In-Reply-To: <20260316180202.3371477-3-justin.chen@broadcom.com>
On 3/16/26 11:02, justin.chen@broadcom.com wrote:
> From: Justin Chen <justin.chen@broadcom.com>
>
> Switch to devm_clk_get_optional() so we can manage the clock ourselves.
> We dynamically control the clocks depending on the state of the interface
> for power savings. The default state is clock disabled, so unbinding the
> driver causes a double disable.
>
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2026-03-16 19:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 18:02 [PATCH net v2 0/2] net: bcmasp: Fix issues during driver unbind justin.chen
2026-03-16 18:02 ` [PATCH net v2 1/2] net: bcmasp: fix double free of WoL irq justin.chen
2026-03-16 19:14 ` Florian Fainelli
2026-03-16 18:02 ` [PATCH net v2 2/2] net: bcmasp: fix double disable of clk justin.chen
2026-03-16 19:14 ` Florian Fainelli [this message]
2026-03-19 0:58 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b63ed1da-ea55-49a7-8e25-03f85535d51c@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox