netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Lena Wang (王娜)" <Lena.Wang@mediatek.com>
To: "horms@kernel.org" <horms@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dsahern@kernel.org" <dsahern@kernel.org>,
	"jiri@resnulli.us" <jiri@resnulli.us>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"Shiming Cheng (成诗明)" <Shiming.Cheng@mediatek.com>,
	"edumazet@google.com" <edumazet@google.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH net v4] ipv6: fib6_rules: flush route cache when rule is changed
Date: Wed, 6 Mar 2024 07:28:39 +0000	[thread overview]
Message-ID: <b642c63273f0dd25dbde3a48aa61903f74ac6b92.camel@mediatek.com> (raw)
In-Reply-To: <20240305152301.GN2357@kernel.org>

On Tue, 2024-03-05 at 15:23 +0000, Simon Horman wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  On Tue, Mar 05, 2024 at 01:01:24PM +0000, Lena Wang (王娜) wrote:
> > On Mon, 2024-03-04 at 20:45 -0800, Jakub Kicinski wrote:
> > >   
> > > External email : Please do not click links or open attachments
> until
> > > you have verified the sender or the content.
> > >  On Fri, 1 Mar 2024 14:39:46 +0000 Lena Wang (王娜) wrote:
> > > > From: Shiming Cheng <shiming.cheng@mediatek.com>
> > > > 
> > > > When rule policy is changed, ipv6 socket cache is not
> refreshed.
> > > > The sock's skb still uses a outdated route cache and was sent
> to
> > > > a wrong interface.
> > > > 
> > > > To avoid this error we should update fib node's version when
> > > > rule is changed. Then skb's route will be reroute checked as
> > > > route cache version is already different with fib node version.
> > > > The route cache is refreshed to match the latest rule.
> > > 
> > > Doesn't apply, please rebase on top of latest net/main.
> > Hi Jakub,
> > I use master branch to make this patch. And it seems same with
> > main branch of kernel/git/netdev/net.git.
> > 
> > Could you tell me which branch should be used?
> > 
> > Thanks
> > Lena
> 
> Hi Lena,
> 
> The primary branch is main these days.
> If you are using master than it may well be stale.
> 
> For reference, the current HEAD commit is.
> 
> 4daa873133d3 ("Merge tag 'mlx5-fixes-2024-03-01' of
> git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux")

Hi Simon,
I clone a latest netdev main branch (on the 4daa873133d3) and make a
new patch diff. However it is totally same with PATCH v4.

Could you please help to check where the stale code is? 


Thanks
Lena


  reply	other threads:[~2024-03-06  7:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-01 14:39 [PATCH net v4] ipv6: fib6_rules: flush route cache when rule is changed Lena Wang (王娜)
2024-03-01 15:27 ` David Ahern
2024-03-01 15:28 ` Jiri Pirko
2024-03-05  4:45 ` Jakub Kicinski
2024-03-05 13:01   ` Lena Wang (王娜)
2024-03-05 15:23     ` Simon Horman
2024-03-06  7:28       ` Lena Wang (王娜) [this message]
2024-03-06 15:08         ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b642c63273f0dd25dbde3a48aa61903f74ac6b92.camel@mediatek.com \
    --to=lena.wang@mediatek.com \
    --cc=Shiming.Cheng@mediatek.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).