From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88ABB20B209 for ; Fri, 10 Jan 2025 09:48:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736502485; cv=none; b=p7Sg2d2pcx42zN8gkaJF6UXOGKbSlaqENqTOBFAzwFfYgWYXTUY+C75wlVcBNMdSy5UnVqBOGDnqjI9dsTr3hYj+KWutPLpAG+e9EolREEZ2NMUGGQpO3JYzKNKgJjvh7h3/b518rzPlI9i3HeyVv2gonuEINApU4J3p7CAM+p0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736502485; c=relaxed/simple; bh=kVRbfJjqPGz8mIX7HYr5rAjUJTIc7wg/ASHsghAXszw=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=oeDAJ/ttiqOMm4x/atR907Y8xzcMzFr6x1waOqmqhEIk1r/nCcasZPM8dKnUTy4wC5dkQGIXc9c93cJ88hYStCNhOPrOHBQySwwqv4fimE/SeSLRepzNEnDyHGltkyG311wcNgXzyZObI7NIzaT8SDpxk8P93brQD2f8ttsdLik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com; spf=pass smtp.mailfrom=daynix.com; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b=KhKUUmvS; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=daynix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=daynix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=daynix-com.20230601.gappssmtp.com header.i=@daynix-com.20230601.gappssmtp.com header.b="KhKUUmvS" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-21631789fcdso38495555ad.1 for ; Fri, 10 Jan 2025 01:48:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1736502483; x=1737107283; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=32Vr4Gt1G1myfrpAERq6AqxVOpF64+scMP61EbgQiWY=; b=KhKUUmvSNnIsRuykpmg5oIG3LsDRZYWxhZlb8W5Y/NscKj6mBRqDvVezPr0kZs2hEk SfgNrsDdakX8JelJlPc2k1axQb33aiz2I5rqfH9DwjbeJIsY0Y0KdOKuIdwLv7bFyXDI xA2Jier5VQgpTBaIeWTrGjgFTJGqCASVNCmseO9gehJzAa7rA+93QUUbNwSTfSa66KTY DwtpqFCBlrO/MBDlZ8TfKY7jYIXUy57fD1WpjPOjRsjT55QZxazx0chlxzTKLVy+Lh1W Jt9Or55j4pbduwenjytpVbKZsHApqCH/5GLCeZEjL9KGtZ4vCpps1r0RVkHX+P12sh0N DIiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736502483; x=1737107283; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=32Vr4Gt1G1myfrpAERq6AqxVOpF64+scMP61EbgQiWY=; b=nvEHq3XpuNSM0DSnFbUVY40P6rnMuKPkyoux92ydglMbXGC6dK+QdeOYNymIqiVgkK m30uZtIJ/hCJ+MOrH5oWeT57Pth3xafHa5C5Gr3LXUVrW4HyZmrMnwgWfV3n6SsZdVFL UYamKhgPhk7d2xl3Ytd6CosIPqp0BFNWG1TEHzb0A/HZhuLI3klkxW69QekVt1kPxHZX L5zO//H5R2u5akcLLA+pEr2gnSPSLq7vjGwkJZV6XAKxzmaPCe13s1qoiFteN+ClD0bp k79l285U++ferk8ImtpSFAT72A8brzGU9KX0ivigzPRRp8SvVfSk5JeQcT/jM5j3Pv8A eQxw== X-Forwarded-Encrypted: i=1; AJvYcCX43JlonLyguIogbqTKy1b7c8M+it5XASW0VdSCdJLx8BVHJkCtg2/G9m5BxIoP6b7/mjv4/Zc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4fP3acVdp1H48o9AHqrc5byMGMN4OG9AyZfZOomFRmIRFhsr6 53CCDKGuniYBh2CocwsDmE4fpbUepjCVsi2+gpX7mEkp4gG79e/wp3C3nroGi+M= X-Gm-Gg: ASbGnct8z09Op+CH2agd5BjNlqJ6NQVWFFa4kRI0MW2Sd5jUD5K+t5eSzUQyuyprjvn o8lQzocs+jKpZCoe1JLwt8Ww56tNnK1FmOS9X49hG7ekSq8qdrSLYKOA2xr9OBem4/eUS5W4SBG siAN5iDReMWMkUruKu7vQnTWeu6LErQp0CJ7PeH3vNcvsOk8nSgdMcROSrhUNVoZXZbDPmxHozi +jKrDjb747E4CsTqf83SZOVwVV5QHK2hFVndqX3aTgZ7t7I9lbZ3sB+LFNqVv/duv4= X-Google-Smtp-Source: AGHT+IG4bZICCGUJL8IFrqqswdhSk8TqvGQUJNKkxBrtJDASy/wZzUeIl0i4xzyDL1lhN+MfLWTweA== X-Received: by 2002:a17:90a:d448:b0:2ee:c30f:33c9 with SMTP id 98e67ed59e1d1-2f55838d0eamr8537569a91.14.1736502482736; Fri, 10 Jan 2025 01:48:02 -0800 (PST) Received: from [157.82.203.37] ([157.82.203.37]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f12f94asm10822555ad.72.2025.01.10.01.47.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 01:48:02 -0800 (PST) Message-ID: Date: Fri, 10 Jan 2025 18:47:56 +0900 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 5/6] selftest: tun: Add tests for virtio-net hashing To: Willem de Bruijn , Jonathan Corbet , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Michael S. Tsirkin" , Xuan Zhuo , Shuah Khan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kselftest@vger.kernel.org, Yuri Benditovich , Andrew Melnychenko , Stephen Hemminger , gur.stavi@huawei.com References: <20250109-rss-v6-0-b1c90ad708f6@daynix.com> <20250109-rss-v6-5-b1c90ad708f6@daynix.com> <677fdee2b56d_362bc129446@willemb.c.googlers.com.notmuch> Content-Language: en-US From: Akihiko Odaki In-Reply-To: <677fdee2b56d_362bc129446@willemb.c.googlers.com.notmuch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025/01/09 23:36, Willem de Bruijn wrote: > Akihiko Odaki wrote: >> The added tests confirm tun can perform RSS and hash reporting, and >> reject invalid configurations for them. >> >> Signed-off-by: Akihiko Odaki >> --- >> tools/testing/selftests/net/Makefile | 2 +- >> tools/testing/selftests/net/tun.c | 558 ++++++++++++++++++++++++++++++++++- >> 2 files changed, 551 insertions(+), 9 deletions(-) >> >> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile >> index cb2fc601de66..92762ce3ebd4 100644 >> --- a/tools/testing/selftests/net/Makefile >> +++ b/tools/testing/selftests/net/Makefile >> @@ -121,6 +121,6 @@ $(OUTPUT)/reuseport_bpf_numa: LDLIBS += -lnuma >> $(OUTPUT)/tcp_mmap: LDLIBS += -lpthread -lcrypto >> $(OUTPUT)/tcp_inq: LDLIBS += -lpthread >> $(OUTPUT)/bind_bhash: LDLIBS += -lpthread >> -$(OUTPUT)/io_uring_zerocopy_tx: CFLAGS += -I../../../include/ >> +$(OUTPUT)/io_uring_zerocopy_tx $(OUTPUT)/tun: CFLAGS += -I../../../include/ >> >> include bpf.mk >> diff --git a/tools/testing/selftests/net/tun.c b/tools/testing/selftests/net/tun.c >> index 463dd98f2b80..9424d897e341 100644 >> --- a/tools/testing/selftests/net/tun.c >> +++ b/tools/testing/selftests/net/tun.c >> @@ -2,21 +2,37 @@ >> >> #define _GNU_SOURCE >> >> +#include >> #include >> #include >> +#include >> #include >> #include >> #include >> #include >> -#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> #include >> +#include >> #include >> #include >> -#include >> -#include >> +#include >> +#include >> +#include >> +#include > > Are all these include changes strictly needed? Iff so, might as well > fix ordering to be alphabetical (lexicographic). > Yes. I placed header files in linux/ after the other header files because include/uapi/linux/libc-compat.h requires libc header files to be placed before linux/ ones.