From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25109140E5F; Fri, 8 May 2026 12:26:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778243183; cv=none; b=p8JHTUuL8YfFoc8M0tt3cPJ4/OPkIa+5IN26QKECbmKkrK2SBJJqzU29+ukheI6aGRrM58mepspwaz84O0RYu2MFgkWbLWDZG/MU9t7aUbKMHLwMRxKuapwWmynYp6Qsgannn4oVJBfuAeZKTnzaRkv1NXg6QasDj7srSlRQovI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778243183; c=relaxed/simple; bh=NLsH/K7VXedzOuGGqbtSWxnkuFBGclsNhZ5CMAY3NHE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EkQtKvmQOq8Ee0ffPpgRElofwoWJd9wC98ctLctEjbKX1TDAN0SnOOfI5V379pcGqg3P2KYclhrVN4gFeM1SZ0oWAbZcEGMEE4UITEWWOQMFkhpDmG7dtE29x5Iy6jqt6ASu9IYbLpcU1BU8Uam+G0tkeoc+uoCC8DCaOhLywu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=jLgL8V3U; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="jLgL8V3U" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=jD++zbm7TRn7z9Gkmzdiydf261KgGUA5U+K5FfJeBoo=; b=jLgL8V3UndE/w2kjJUn6i6q94l F73Njt0/LztH/sr56sNrLKGbBNgXWO7eUZxv7yR7eSl8UXM6nTAz5gS9CAICg9nvQXIAHQTHVq4uF XujQotNRJVZZeY/ZeLoZ7TOZUYKj58RrwlwF6gNyk/pn3VJHaNMJ8N0A47Y/OgLVlvIA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1wLKHS-001xtk-Lp; Fri, 08 May 2026 14:26:10 +0200 Date: Fri, 8 May 2026 14:26:10 +0200 From: Andrew Lunn To: Sven Schuchmann Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, maxime.chevallier@bootlin.com Subject: Re: [PATCH] net: phy: DP83TC811: add reading of abilities Message-ID: References: <20260508074931.8226-1-schuchmann@schleissheimer.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260508074931.8226-1-schuchmann@schleissheimer.de> On Fri, May 08, 2026 at 09:37:43AM +0200, Sven Schuchmann wrote: > At this time the driver is not listing any speeds > it supports. This should be ETHTOOL_LINK_MODE_100baseT1_Full_BIT > for DP83TC811. Add the missing call for phylib to read the abilities. > > Signed-off-by: Sven Schuchmann > Suggested-by: Andrew Lunn Hi Sven A good first attempt. Two things which should be improved. netdev uses two trees. "net-next" for ongoing development work, and "net" for fixes which will be backported in stable. This is a fix, so should be on the "net" tree, and the Subject: line should indicate "net": https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#git-trees-and-patch-flow Since this is a Fix, it needs a Fixes: tag, indicating where the issue was introduced. The history is interesting. When it was first introduced in commit b753a9faaf9aef1338c28ebd9ace6d749428788b Author: Dan Murphy Date: Fri May 11 13:08:19 2018 -0500 it had: +static struct phy_driver dp83811_driver[] = { + { + .phy_id = DP83TC811_PHY_ID, + .phy_id_mask = 0xfffffff0, + .name = "TI DP83TC811", + .features = PHY_BASIC_FEATURES, The commit message does not mention it is a T1 PHY. PHY_BASIC_FEATURES means it is a standard 10/100 BASE-T PHY, not a T1 PHY. Then in commit dcdecdcfe1fc39ded8590aed2fe84d62f14b2392 Author: Heiner Kallweit Date: Fri Apr 12 20:47:03 2019 +0200 net: phy: switch drivers to use dynamic feature detection That line got commented out, when we starting using the registers of the PHY to enumerate its capabilities. So at that point, it want from being a 10/100 BASE-T to not listing any link modes. I would say it was wrong from the beginning, so use of Fixes: tag of. Fixes: b753a9faaf9a ("net: phy: DP83TC811: Introduce support for the DP83TC811 phy") Anybody trying to backport the fix that far will fail, because genphy_c45_pma_read_ext_abilities() did not exist back then. But it should work for modern LTS kernels. Andrew --- pw-bot: cr