* [PATCH net] net: netlink: rename NETLINK_DUMP_STRICT_CHK -> NETLINK_GET_STRICT_CHK
@ 2018-12-14 19:38 Jakub Kicinski
2018-12-14 19:40 ` David Ahern
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2018-12-14 19:38 UTC (permalink / raw)
To: davem; +Cc: dsahern, roopa, nikolay, stephen, netdev, oss-drivers,
Jakub Kicinski
NETLINK_DUMP_STRICT_CHK can be used for all GET requests,
dumps as well as doit handlers. Replace the DUMP in the
name with GET make that clearer.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
---
include/uapi/linux/netlink.h | 2 +-
net/netlink/af_netlink.c | 4 ++--
tools/include/uapi/linux/netlink.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/uapi/linux/netlink.h b/include/uapi/linux/netlink.h
index 486ed1f0c0bc..0a4d73317759 100644
--- a/include/uapi/linux/netlink.h
+++ b/include/uapi/linux/netlink.h
@@ -155,7 +155,7 @@ enum nlmsgerr_attrs {
#define NETLINK_LIST_MEMBERSHIPS 9
#define NETLINK_CAP_ACK 10
#define NETLINK_EXT_ACK 11
-#define NETLINK_DUMP_STRICT_CHK 12
+#define NETLINK_GET_STRICT_CHK 12
struct nl_pktinfo {
__u32 group;
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 6bb9f3cde0b0..3c023d6120f6 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1706,7 +1706,7 @@ static int netlink_setsockopt(struct socket *sock, int level, int optname,
nlk->flags &= ~NETLINK_F_EXT_ACK;
err = 0;
break;
- case NETLINK_DUMP_STRICT_CHK:
+ case NETLINK_GET_STRICT_CHK:
if (val)
nlk->flags |= NETLINK_F_STRICT_CHK;
else
@@ -1806,7 +1806,7 @@ static int netlink_getsockopt(struct socket *sock, int level, int optname,
return -EFAULT;
err = 0;
break;
- case NETLINK_DUMP_STRICT_CHK:
+ case NETLINK_GET_STRICT_CHK:
if (len < sizeof(int))
return -EINVAL;
len = sizeof(int);
diff --git a/tools/include/uapi/linux/netlink.h b/tools/include/uapi/linux/netlink.h
index 486ed1f0c0bc..0a4d73317759 100644
--- a/tools/include/uapi/linux/netlink.h
+++ b/tools/include/uapi/linux/netlink.h
@@ -155,7 +155,7 @@ enum nlmsgerr_attrs {
#define NETLINK_LIST_MEMBERSHIPS 9
#define NETLINK_CAP_ACK 10
#define NETLINK_EXT_ACK 11
-#define NETLINK_DUMP_STRICT_CHK 12
+#define NETLINK_GET_STRICT_CHK 12
struct nl_pktinfo {
__u32 group;
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net: netlink: rename NETLINK_DUMP_STRICT_CHK -> NETLINK_GET_STRICT_CHK
2018-12-14 19:38 [PATCH net] net: netlink: rename NETLINK_DUMP_STRICT_CHK -> NETLINK_GET_STRICT_CHK Jakub Kicinski
@ 2018-12-14 19:40 ` David Ahern
2018-12-14 19:44 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: David Ahern @ 2018-12-14 19:40 UTC (permalink / raw)
To: Jakub Kicinski, davem; +Cc: roopa, nikolay, stephen, netdev, oss-drivers
On 12/14/18 12:38 PM, Jakub Kicinski wrote:
> NETLINK_DUMP_STRICT_CHK can be used for all GET requests,
> dumps as well as doit handlers. Replace the DUMP in the
> name with GET make that clearer.
>
> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> ---
> include/uapi/linux/netlink.h | 2 +-
> net/netlink/af_netlink.c | 4 ++--
> tools/include/uapi/linux/netlink.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] net: netlink: rename NETLINK_DUMP_STRICT_CHK -> NETLINK_GET_STRICT_CHK
2018-12-14 19:40 ` David Ahern
@ 2018-12-14 19:44 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2018-12-14 19:44 UTC (permalink / raw)
To: dsahern; +Cc: jakub.kicinski, roopa, nikolay, stephen, netdev, oss-drivers
From: David Ahern <dsahern@gmail.com>
Date: Fri, 14 Dec 2018 12:40:34 -0700
> On 12/14/18 12:38 PM, Jakub Kicinski wrote:
>> NETLINK_DUMP_STRICT_CHK can be used for all GET requests,
>> dumps as well as doit handlers. Replace the DUMP in the
>> name with GET make that clearer.
>>
>> Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
>> ---
>> include/uapi/linux/netlink.h | 2 +-
>> net/netlink/af_netlink.c | 4 ++--
>> tools/include/uapi/linux/netlink.h | 2 +-
>> 3 files changed, 4 insertions(+), 4 deletions(-)
>>
>
> Reviewed-by: David Ahern <dsahern@gmail.com>
Applied, luckily we can still do this.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-14 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-14 19:38 [PATCH net] net: netlink: rename NETLINK_DUMP_STRICT_CHK -> NETLINK_GET_STRICT_CHK Jakub Kicinski
2018-12-14 19:40 ` David Ahern
2018-12-14 19:44 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).