* [PATCH net-next] net: ena: Remove redundant assignment
@ 2024-02-13 3:17 Kamal Heib
2024-02-13 4:10 ` Brett Creeley
2024-02-14 11:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 4+ messages in thread
From: Kamal Heib @ 2024-02-13 3:17 UTC (permalink / raw)
To: netdev, David S . Miller, Jakub Kicinski
Cc: Shay Agroskin, David Arinzon, Kamal Heib
There is no point in initializing an ndo to NULL, therefor the
assignment is redundant and can be removed.
Signed-off-by: Kamal Heib <kheib@redhat.com>
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 1c0a7828d397..88d7e785e10f 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -2867,7 +2867,6 @@ static const struct net_device_ops ena_netdev_ops = {
.ndo_get_stats64 = ena_get_stats64,
.ndo_tx_timeout = ena_tx_timeout,
.ndo_change_mtu = ena_change_mtu,
- .ndo_set_mac_address = NULL,
.ndo_validate_addr = eth_validate_addr,
.ndo_bpf = ena_xdp,
.ndo_xdp_xmit = ena_xdp_xmit,
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] net: ena: Remove redundant assignment
2024-02-13 3:17 [PATCH net-next] net: ena: Remove redundant assignment Kamal Heib
@ 2024-02-13 4:10 ` Brett Creeley
2024-02-13 9:18 ` Kiyanovski, Arthur
2024-02-14 11:00 ` patchwork-bot+netdevbpf
1 sibling, 1 reply; 4+ messages in thread
From: Brett Creeley @ 2024-02-13 4:10 UTC (permalink / raw)
To: Kamal Heib, netdev, David S . Miller, Jakub Kicinski
Cc: Shay Agroskin, David Arinzon
On 2/12/2024 7:17 PM, Kamal Heib wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> There is no point in initializing an ndo to NULL, therefor the
> assignment is redundant and can be removed.
>
> Signed-off-by: Kamal Heib <kheib@redhat.com>
Reviewed-by: Brett Creeley <brett.creeley@amd.com>
> ---
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 1c0a7828d397..88d7e785e10f 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -2867,7 +2867,6 @@ static const struct net_device_ops ena_netdev_ops = {
> .ndo_get_stats64 = ena_get_stats64,
> .ndo_tx_timeout = ena_tx_timeout,
> .ndo_change_mtu = ena_change_mtu,
> - .ndo_set_mac_address = NULL, > .ndo_validate_addr = eth_validate_addr,
> .ndo_bpf = ena_xdp,
> .ndo_xdp_xmit = ena_xdp_xmit,
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH net-next] net: ena: Remove redundant assignment
2024-02-13 4:10 ` Brett Creeley
@ 2024-02-13 9:18 ` Kiyanovski, Arthur
0 siblings, 0 replies; 4+ messages in thread
From: Kiyanovski, Arthur @ 2024-02-13 9:18 UTC (permalink / raw)
To: Brett Creeley, Kamal Heib, netdev@vger.kernel.org,
David S . Miller, Jakub Kicinski
Cc: Agroskin, Shay, Arinzon, David
> -----Original Message-----
> From: Brett Creeley <bcreeley@amd.com>
> Sent: Tuesday, February 13, 2024 6:11 AM
> To: Kamal Heib <kheib@redhat.com>; netdev@vger.kernel.org; David S .
> Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>
> Cc: Agroskin, Shay <shayagr@amazon.com>; Arinzon, David
> <darinzon@amazon.com>
> Subject: RE: [EXTERNAL] [PATCH net-next] net: ena: Remove redundant
> assignment
>
> CAUTION: This email originated from outside of the organization. Do not click
> links or open attachments unless you can confirm the sender and know the
> content is safe.
>
>
>
> On 2/12/2024 7:17 PM, Kamal Heib wrote:
> > Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> >
> >
> > There is no point in initializing an ndo to NULL, therefor the
> > assignment is redundant and can be removed.
> >
> > Signed-off-by: Kamal Heib <kheib@redhat.com>
>
>
> Reviewed-by: Brett Creeley <brett.creeley@amd.com>
>
Thanks for submitting this commit.
Nit: therfor=>therefore
Otherwise,
Acked-by: Arthur Kiyanovski <akiyano@amazon.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: ena: Remove redundant assignment
2024-02-13 3:17 [PATCH net-next] net: ena: Remove redundant assignment Kamal Heib
2024-02-13 4:10 ` Brett Creeley
@ 2024-02-14 11:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-14 11:00 UTC (permalink / raw)
To: Kamal Heib; +Cc: netdev, davem, kuba, shayagr, darinzon
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Mon, 12 Feb 2024 22:17:18 -0500 you wrote:
> There is no point in initializing an ndo to NULL, therefor the
> assignment is redundant and can be removed.
>
> Signed-off-by: Kamal Heib <kheib@redhat.com>
> ---
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [net-next] net: ena: Remove redundant assignment
https://git.kernel.org/netdev/net-next/c/723615a14b87
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-14 11:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-13 3:17 [PATCH net-next] net: ena: Remove redundant assignment Kamal Heib
2024-02-13 4:10 ` Brett Creeley
2024-02-13 9:18 ` Kiyanovski, Arthur
2024-02-14 11:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).