From: Steven Harms <thisdyingdream@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: sjharms@gmail.com, mcarlson@broadcom.com, mchan@broadcom.com,
benli@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, sharms@ubuntu.com
Subject: Re: [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style g
Date: Sat, 13 Mar 2010 14:52:26 -0500 [thread overview]
Message-ID: <b6bf7b051003131152t38c8b1e1m33e8844468b9e46a@mail.gmail.com> (raw)
David,
Would you like me to submit the patch adding only the spaces after
commas and leave the rest of the defines as is, or discard the changes
all together?
On Sat, Mar 13, 2010 at 2:49 PM, David Miller <davem@davemloft.net> wrote:
> From: Steven Harms <sjharms@gmail.com>
> Date: Sat, 13 Mar 2010 14:39:11 -0500
>
>> -#define tw32_mailbox(reg, val) tp->write32_mbox(tp, reg, val)
>> -#define tw32_mailbox_f(reg, val) tw32_mailbox_flush(tp, (reg), (val))
>> -#define tw32_rx_mbox(reg, val) tp->write32_rx_mbox(tp, reg, val)
>> -#define tw32_tx_mbox(reg, val) tp->write32_tx_mbox(tp, reg, val)
>> -#define tr32_mailbox(reg) tp->read32_mbox(tp, reg)
>> +#define tw32_mailbox(reg, val) (tp->write32_mbox(tp, reg, val))
>
> Please keep this kind of code masterbation to yourself.
> This is not the style we want for this driver.
>
--
GPG Key ID: C92EF367 / 1428 FE8E 1E07 DDA8 EFD7 195F DCCD F5B3 C92E F367
WWW: http://www.sharms.org/blog
next reply other threads:[~2010-03-13 19:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-13 19:52 Steven Harms [this message]
2010-03-13 19:55 ` [PATCH] NET: tg3: fix brace, switch, and comma spacing coding style in tg3.c This is a patch to the tg3.c file that aligns switch and case statements, else statements following braces, and inserts a space after commas listed in the coding style g David Miller
2010-03-13 20:22 ` Joe Perches
2010-03-15 18:39 ` Matt Carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6bf7b051003131152t38c8b1e1m33e8844468b9e46a@mail.gmail.com \
--to=thisdyingdream@gmail.com \
--cc=benli@broadcom.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=sharms@ubuntu.com \
--cc=sjharms@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).