From: David Ahern <dsahern@gmail.com>
To: Petr Machata <me@pmachata.org>, David Ahern <dsahern@kernel.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next] Only compile mnl_utils when HAVE_LIBMNL is defined
Date: Thu, 3 Dec 2020 15:39:49 -0700 [thread overview]
Message-ID: <b6c07397-9799-e9f4-23c7-e1954ee701b5@gmail.com> (raw)
In-Reply-To: <87o8jamum5.fsf@nvidia.com>
On 12/3/20 2:45 PM, Petr Machata wrote:
>
> David Ahern <dsahern@kernel.org> writes:
>
>> diff --git a/lib/Makefile b/lib/Makefile
>> index e37585c6..603ea83e 100644
>> --- a/lib/Makefile
>> +++ b/lib/Makefile
>> @@ -13,7 +13,10 @@ UTILOBJ += bpf_libbpf.o
>> endif
>> endif
>>
>> -NLOBJ=libgenl.o libnetlink.o mnl_utils.o
>> +NLOBJ=libgenl.o libnetlink.o
>> +ifeq ($(HAVE_LIBMNL),y)
>
> This should test HAVE_MNL, not HAVE_LIBMNL.
>
d'oh. thanks for catching that.
prev parent reply other threads:[~2020-12-03 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 4:11 [PATCH iproute2-next] Only compile mnl_utils when HAVE_LIBMNL is defined David Ahern
2020-12-03 21:45 ` Petr Machata
2020-12-03 22:39 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c07397-9799-e9f4-23c7-e1954ee701b5@gmail.com \
--to=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=me@pmachata.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).