From: David Ahern <dsahern@gmail.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, Oliver Hartkopp <oliver@hartkopp.net>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH net] net: enable interface alias removal via rtnl
Date: Fri, 6 Oct 2017 12:18:44 -0600 [thread overview]
Message-ID: <b6c121f1-c585-6fa4-8dc9-8847ea5ee20c@gmail.com> (raw)
In-Reply-To: <20171005101940.28550-1-nicolas.dichtel@6wind.com>
On 10/5/17 4:19 AM, Nicolas Dichtel wrote:
> IFLA_IFALIAS is defined as NLA_STRING. It means that the minimal length of
> the attribute is 1 ("\0"). However, to remove an alias, the attribute
> length must be 0 (see dev_set_alias()).
why not add a check in dev_set_alias that if len is 1 and the 1
character is '\0' it means remove the alias?
>
> Let's define the type to NLA_BINARY, so that the alias can be removed.
that changes the uapi
next prev parent reply other threads:[~2017-10-06 18:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 10:19 [PATCH net] net: enable interface alias removal via rtnl Nicolas Dichtel
2017-10-06 18:18 ` David Ahern [this message]
2017-10-06 20:10 ` Oliver Hartkopp
2017-10-09 8:23 ` Nicolas Dichtel
2017-10-09 14:02 ` David Ahern
2017-10-09 15:25 ` Nicolas Dichtel
2017-10-09 21:17 ` David Ahern
2017-10-10 12:41 ` [PATCH net v2] " Nicolas Dichtel
2017-10-10 14:50 ` David Ahern
2017-10-11 12:29 ` Nicolas Dichtel
2017-10-11 14:13 ` David Ahern
2017-10-11 14:24 ` [PATCH net v3] " Nicolas Dichtel
2017-10-16 19:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6c121f1-c585-6fa4-8dc9-8847ea5ee20c@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=oliver@hartkopp.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).