Re: [PATCH net] net: dsa: mt7530: do not advertise EEE on MT7621 switch

[Andrew Lunn <andrew@lunn.ch>]

On Thu, Aug 20, 2026 at 11:18:23PM +0300, Vladislav Karmanov wrote:
> Hi Andrew, Hi Daniel,
> 
> Thanks for the review.
> 
> > Do we know what is broken here? MAC or PHY? If it is the PHY which is
> > broken, it would be better to put the workaround into the PHY driver.
> 
> It is the PHY that is broken -- the MT7530 internal GE PHY (PHY ID
> 0x03a29412, driven by mediatek-ge). Landen Chao (MediaTek, 2021) puts the
> root cause there: "EEE of the 10-year-old MT7530 internal gephy has many
> IOT problems, so it is recommended to disable its EEE."
> 
> That would point to the PHY driver as the natural home, but I think the
> DSA side is actually the right place,

There are a couple of parts to disabling EEE.

In this case, you need to disable advertise early. So the PHY probe()
would be the correct place to do this.

You also needs to let phylib know that EEE is broken. So the PHY
driver should be calling phy_disable_eee(). That will prevent the user
from turning EEE back on again.

Since it is the PHY which is broken, this will cover all usage of the
PHY, be it integrated in a switch, or standalone.

     Andrew