netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: dsa: mt7530: make NET_DSA_MT7530 select MEDIATEK_GE_PHY
@ 2022-01-28 17:05 Arınç ÜNAL
  2022-01-28 17:18 ` Andrew Lunn
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Arınç ÜNAL @ 2022-01-28 17:05 UTC (permalink / raw)
  To: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
	David S . Miller, DENG Qingfang, erkin.bozoglu
  Cc: netdev, Arınç ÜNAL

Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
properly control MT7530 and MT7531 switch PHYs.

A noticeable change is that the behaviour of switchport interfaces going
up-down-up-down is no longer there.

Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
---
 drivers/net/dsa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
index 7b1457a6e327..c0c91440340a 100644
--- a/drivers/net/dsa/Kconfig
+++ b/drivers/net/dsa/Kconfig
@@ -36,6 +36,7 @@ config NET_DSA_LANTIQ_GSWIP
 config NET_DSA_MT7530
 	tristate "MediaTek MT753x and MT7621 Ethernet switch support"
 	select NET_DSA_TAG_MTK
+	select MEDIATEK_GE_PHY
 	help
 	  This enables support for the MediaTek MT7530, MT7531, and MT7621
 	  Ethernet switch chips.
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH] net: dsa: mt7530: make NET_DSA_MT7530 select MEDIATEK_GE_PHY
  2022-01-28 17:05 [PATCH] net: dsa: mt7530: make NET_DSA_MT7530 select MEDIATEK_GE_PHY Arınç ÜNAL
@ 2022-01-28 17:18 ` Andrew Lunn
  2022-01-28 17:30 ` Florian Fainelli
  2022-01-28 22:31 ` Jakub Kicinski
  2 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2022-01-28 17:18 UTC (permalink / raw)
  To: Arınç ÜNAL
  Cc: Vivien Didelot, Florian Fainelli, Vladimir Oltean,
	David S . Miller, DENG Qingfang, erkin.bozoglu, netdev

On Fri, Jan 28, 2022 at 08:05:45PM +0300, Arınç ÜNAL wrote:
> Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
> properly control MT7530 and MT7531 switch PHYs.
> 
> A noticeable change is that the behaviour of switchport interfaces going
> up-down-up-down is no longer there.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] net: dsa: mt7530: make NET_DSA_MT7530 select MEDIATEK_GE_PHY
  2022-01-28 17:05 [PATCH] net: dsa: mt7530: make NET_DSA_MT7530 select MEDIATEK_GE_PHY Arınç ÜNAL
  2022-01-28 17:18 ` Andrew Lunn
@ 2022-01-28 17:30 ` Florian Fainelli
  2022-01-28 22:31 ` Jakub Kicinski
  2 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2022-01-28 17:30 UTC (permalink / raw)
  To: Arınç ÜNAL, Andrew Lunn, Vivien Didelot,
	Vladimir Oltean, David S . Miller, DENG Qingfang, erkin.bozoglu
  Cc: netdev



On 1/28/2022 9:05 AM, Arınç ÜNAL wrote:
> Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
> properly control MT7530 and MT7531 switch PHYs.
> 
> A noticeable change is that the behaviour of switchport interfaces going
> up-down-up-down is no longer there.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] net: dsa: mt7530: make NET_DSA_MT7530 select MEDIATEK_GE_PHY
  2022-01-28 17:05 [PATCH] net: dsa: mt7530: make NET_DSA_MT7530 select MEDIATEK_GE_PHY Arınç ÜNAL
  2022-01-28 17:18 ` Andrew Lunn
  2022-01-28 17:30 ` Florian Fainelli
@ 2022-01-28 22:31 ` Jakub Kicinski
  2022-01-29  6:31   ` Arınç ÜNAL
  2 siblings, 1 reply; 5+ messages in thread
From: Jakub Kicinski @ 2022-01-28 22:31 UTC (permalink / raw)
  To: Arınç ÜNAL
  Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
	David S . Miller, DENG Qingfang, erkin.bozoglu, netdev

On Fri, 28 Jan 2022 20:05:45 +0300 Arınç ÜNAL wrote:
> Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
> properly control MT7530 and MT7531 switch PHYs.
> 
> A noticeable change is that the behaviour of switchport interfaces going
> up-down-up-down is no longer there.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>

Sounds like a fix, can we get a Fixes tag?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] net: dsa: mt7530: make NET_DSA_MT7530 select MEDIATEK_GE_PHY
  2022-01-28 22:31 ` Jakub Kicinski
@ 2022-01-29  6:31   ` Arınç ÜNAL
  0 siblings, 0 replies; 5+ messages in thread
From: Arınç ÜNAL @ 2022-01-29  6:31 UTC (permalink / raw)
  To: Jakub Kicinski
  Cc: Andrew Lunn, Vivien Didelot, Florian Fainelli, Vladimir Oltean,
	David S . Miller, DENG Qingfang, erkin.bozoglu, netdev

On 29/01/2022 01:31, Jakub Kicinski wrote:
> On Fri, 28 Jan 2022 20:05:45 +0300 Arınç ÜNAL wrote:
>> Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
>> properly control MT7530 and MT7531 switch PHYs.
>>
>> A noticeable change is that the behaviour of switchport interfaces going
>> up-down-up-down is no longer there.
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> 
> Sounds like a fix, can we get a Fixes tag?

Sent v2. I didn't realise you weren't in the recipients, sorry.

https://lore.kernel.org/netdev/20220129062703.595-1-arinc.unal@arinc9.com/T/#u

Arınç

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-01-29  6:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-28 17:05 [PATCH] net: dsa: mt7530: make NET_DSA_MT7530 select MEDIATEK_GE_PHY Arınç ÜNAL
2022-01-28 17:18 ` Andrew Lunn
2022-01-28 17:30 ` Florian Fainelli
2022-01-28 22:31 ` Jakub Kicinski
2022-01-29  6:31   ` Arınç ÜNAL

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).