From: David Ahern <dsahern@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, idosch@idosch.org,
roopa@cumulusnetworks.com, eric.dumazet@gmail.com,
weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH RFC net-next 01/20] net: Move fib_convert_metrics to dst core
Date: Mon, 26 Feb 2018 13:07:27 -0700 [thread overview]
Message-ID: <b6fc83fa-2e96-7c10-f0cd-52e3d5328fe3@gmail.com> (raw)
In-Reply-To: <20180226.140544.1684161543332531356.davem@davemloft.net>
On 2/26/18 12:05 PM, David Miller wrote:
> From: David Ahern <dsahern@gmail.com>
> Date: Sun, 25 Feb 2018 11:47:11 -0800
>
>> diff --git a/net/core/dst.c b/net/core/dst.c
>> index 007aa0b08291..5f70bc832bec 100644
>> --- a/net/core/dst.c
>> +++ b/net/core/dst.c
> ...
>> + val = tcp_ca_get_key_by_name(net, tmp, &ecn_ca);
>> + if (val == TCP_CA_UNSPEC)
>> + return -EINVAL;
>
> This makes the networking core depend upon CONFIG_INET.
>
> You will have to untangle this somehow before your final submission.
> Probably with an inline helper in the non-INET case that always
> returns TCP_CA_UNSPEC.
>
good point. Perhaps net/ipv4/metrics.c is a better place for it given
that ipv4/ipv6 common code appears to be under net/ipv4. I need to play
with the config build permutations.
next prev parent reply other threads:[~2018-02-26 20:07 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-25 19:47 [PATCH RFC net-next 00/20] net/ipv6: Separate data structures for FIB and data path David Ahern
2018-02-25 19:47 ` [PATCH RFC net-next 01/20] net: Move fib_convert_metrics to dst core David Ahern
2018-02-26 19:05 ` David Miller
2018-02-26 20:07 ` David Ahern [this message]
2018-02-25 19:47 ` [PATCH RFC net-next 02/20] vrf: Move fib6_table into net_vrf David Ahern
2018-02-26 19:08 ` David Miller
2018-02-26 20:13 ` David Ahern
2018-02-26 20:34 ` David Miller
2018-02-25 19:47 ` [PATCH RFC net-next 03/20] net/ipv6: Pass net to fib6_update_sernum David Ahern
2018-02-25 19:47 ` [PATCH RFC net-next 04/20] net/ipv6: Pass net namespace to route functions David Ahern
2018-02-25 19:47 ` [PATCH RFC net-next 05/20] net/ipv6: Move support functions up in route.c David Ahern
2018-02-25 19:47 ` [PATCH RFC net-next 06/20] net/ipv6: Save route type in rt6_info flags David Ahern
2018-02-25 19:47 ` [PATCH RFC net-next 07/20] net/ipv6: Move nexthop data to fib6_nh David Ahern
2018-02-26 22:28 ` Wei Wang
2018-02-26 22:47 ` David Ahern
2018-02-26 23:05 ` Wei Wang
2018-02-25 19:47 ` [PATCH RFC net-next 08/20] net/ipv6: Defer initialization of dst to data path David Ahern
2018-02-26 19:17 ` David Miller
2018-02-26 20:20 ` David Ahern
2018-02-26 20:22 ` David Miller
2018-02-25 19:47 ` [PATCH RFC net-next 09/20] net/ipv6: move metrics from dst to rt6_info David Ahern
2018-02-27 0:01 ` [net/ipv6] 15c9251fd2: BUG:unable_to_handle_kernel kernel test robot
2018-02-25 19:47 ` [PATCH RFC net-next 10/20] net/ipv6: move expires into rt6_info David Ahern
2018-02-26 22:28 ` Wei Wang
2018-02-26 22:55 ` David Ahern
2018-02-27 0:31 ` Wei Wang
2018-02-28 19:21 ` Martin KaFai Lau
2018-02-28 22:25 ` David Ahern
2018-02-28 22:56 ` Martin KaFai Lau
2018-02-25 19:47 ` [PATCH RFC net-next 11/20] net/ipv6: Add fib6_null_entry David Ahern
2018-02-25 19:47 ` [PATCH RFC net-next 12/20] net/ipv6: Add rt6_info create function for ip6_pol_route_lookup David Ahern
2018-02-25 19:47 ` [PATCH RFC net-next 13/20] net/ipv6: Move dst flags to booleans in fib entries David Ahern
2018-02-25 19:47 ` [PATCH RFC net-next 14/20] net/ipv6: Create a neigh_lookup for FIB entries David Ahern
2018-02-25 19:47 ` [PATCH RFC net-next 15/20] net/ipv6: Add gfp_flags to route add functions David Ahern
2018-02-25 19:47 ` [PATCH RFC net-next 16/20] net/ipv6: Cleanup exception route handling David Ahern
2018-02-26 19:27 ` David Miller
2018-02-26 20:25 ` David Ahern
2018-02-26 20:29 ` David Miller
2018-02-26 22:29 ` Wei Wang
2018-02-26 23:02 ` David Ahern
2018-02-27 0:32 ` Wei Wang
2018-02-25 19:47 ` [PATCH RFC net-next 17/20] net/ipv6: introduce fib6_info struct and helpers David Ahern
2018-02-25 19:47 ` [PATCH RFC net-next 18/20] net/ipv6: separate handling of FIB entries from dst based routes David Ahern
2018-02-28 18:44 ` Martin KaFai Lau
2018-02-28 20:10 ` David Ahern
2018-02-25 19:47 ` [PATCH RFC net-next 19/20] net/ipv6: Flip FIB entries to fib6_info David Ahern
2018-02-25 19:47 ` [PATCH RFC net-next 20/20] net/ipv6: Remove unused code and variables for rt6_info David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6fc83fa-2e96-7c10-f0cd-52e3d5328fe3@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=idosch@idosch.org \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=weiwan@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).