From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f169.google.com ([209.85.192.169]:33712 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750842AbeBZUHa (ORCPT ); Mon, 26 Feb 2018 15:07:30 -0500 Received: by mail-pf0-f169.google.com with SMTP id q13so6969576pff.0 for ; Mon, 26 Feb 2018 12:07:29 -0800 (PST) Subject: Re: [PATCH RFC net-next 01/20] net: Move fib_convert_metrics to dst core To: David Miller Cc: netdev@vger.kernel.org, idosch@idosch.org, roopa@cumulusnetworks.com, eric.dumazet@gmail.com, weiwan@google.com, kafai@fb.com, yoshfuji@linux-ipv6.org References: <20180225194730.30063-1-dsahern@gmail.com> <20180225194730.30063-2-dsahern@gmail.com> <20180226.140544.1684161543332531356.davem@davemloft.net> From: David Ahern Message-ID: Date: Mon, 26 Feb 2018 13:07:27 -0700 MIME-Version: 1.0 In-Reply-To: <20180226.140544.1684161543332531356.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 2/26/18 12:05 PM, David Miller wrote: > From: David Ahern > Date: Sun, 25 Feb 2018 11:47:11 -0800 > >> diff --git a/net/core/dst.c b/net/core/dst.c >> index 007aa0b08291..5f70bc832bec 100644 >> --- a/net/core/dst.c >> +++ b/net/core/dst.c > ... >> + val = tcp_ca_get_key_by_name(net, tmp, &ecn_ca); >> + if (val == TCP_CA_UNSPEC) >> + return -EINVAL; > > This makes the networking core depend upon CONFIG_INET. > > You will have to untangle this somehow before your final submission. > Probably with an inline helper in the non-INET case that always > returns TCP_CA_UNSPEC. > good point. Perhaps net/ipv4/metrics.c is a better place for it given that ipv4/ipv6 common code appears to be under net/ipv4. I need to play with the config build permutations.