From: Alexey Dobriyan <adobriyan@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] ipcomp: double free at ipcomp_destroy()
Date: Mon, 15 Feb 2010 09:32:33 +0200 [thread overview]
Message-ID: <b6fcc0a1002142332r1542e04ex250fa238e4a3231a@mail.gmail.com> (raw)
In-Reply-To: <20100215001849.GB15437@gondor.apana.org.au>
On Mon, Feb 15, 2010 at 2:18 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Sun, Feb 14, 2010 at 04:44:15PM +0200, Alexey Dobriyan wrote:
>> Consider using ipcomp with tunnel mode:
>>
>> pfkey_add -> xfrm_state_init -> x->type->init_state() == ipcomp4_init_state
>>
>> 1. If ipcomp_tunnel_attach() fails, xfrm_state private data (x->data) are freed
>> first time (synchronously), but stale pointer is left.
>> 2. xfrm_state_init() failed, all right, we're going to do error unwind
>> but this time asynchronously and we're going to double free x->data
>> asynchronously.
>
> Sorry, I don't see the async path, where is it?
pfkey_add
pfkey_msg2xfrm_state
xfrm_init_state [fails]
xfrm_state_put
__xfrm_state_destroy [puts xfrm_state into GC list, schedule work]
xfrm_state_gc_task
xfrm_state_gc_destroy
x->type->destructor
next prev parent reply other threads:[~2010-02-15 7:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 14:44 [PATCH] ipcomp: double free at ipcomp_destroy() Alexey Dobriyan
2010-02-15 0:18 ` Herbert Xu
2010-02-15 7:32 ` Alexey Dobriyan [this message]
2010-02-15 8:08 ` Herbert Xu
2010-02-15 8:10 ` Herbert Xu
2010-02-15 15:50 ` Alexey Dobriyan
2010-02-16 5:29 ` Herbert Xu
2010-02-15 17:28 ` Alexey Dobriyan
2010-02-16 5:24 ` Herbert Xu
2010-02-16 23:14 ` David Miller
2010-02-16 6:00 ` Herbert Xu
2010-02-16 23:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6fcc0a1002142332r1542e04ex250fa238e4a3231a@mail.gmail.com \
--to=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).