From: David Ahern <dsahern@gmail.com>
To: Wei Wang <weiwan@google.com>, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: Eric Dumazet <edumazet@google.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Sabrina Dubroca <sd@queasysnail.net>
Subject: Re: [PATCH net 1/2] Revert "ipv6: fix double refcount of fib6_metrics"
Date: Tue, 18 Sep 2018 16:17:08 -0700 [thread overview]
Message-ID: <b7370e1c-0db1-ea8c-b310-aa0a15cfef4d@gmail.com> (raw)
In-Reply-To: <20180918204500.106240-2-tracywwnj@gmail.com>
On 9/18/18 1:44 PM, Wei Wang wrote:
> From: Wei Wang <weiwan@google.com>
>
> This reverts commit e70a3aad44cc8b24986687ffc98c4a4f6ecf25ea.
>
> This change causes use-after-free on dst->_metrics.
....
> Reported-by: John Sperbeck <jsperbeck@google.com>
> Signed-off-by: Wei Wang <weiwan@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> net/ipv6/route.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2018-09-19 4:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 20:44 [PATCH net 0/2] ipv6: fix issues on accessing fib6_metrics Wei Wang
2018-09-18 20:44 ` [PATCH net 1/2] Revert "ipv6: fix double refcount of fib6_metrics" Wei Wang
2018-09-18 20:45 ` [PATCH net 2/2] ipv6: fix memory leak on dst->_metrics Wei Wang
2018-09-18 23:23 ` David Ahern
2018-09-19 1:02 ` Wei Wang
2018-09-18 23:17 ` David Ahern [this message]
2018-09-19 3:17 ` [PATCH net 0/2] ipv6: fix issues on accessing fib6_metrics David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7370e1c-0db1-ea8c-b310-aa0a15cfef4d@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
--cc=weiwan@google.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).