From: Dan Carpenter <dan.carpenter@linaro.org>
To: oe-kbuild@lists.linux.dev, Heng Qi <hengqi@linux.alibaba.com>,
netdev@vger.kernel.org, virtualization@lists.linux.dev,
Jason Wang <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH 2/2] virtio-net: reduce the CPU consumption of dim worker
Date: Fri, 22 Mar 2024 09:50:29 +0300 [thread overview]
Message-ID: <b7392d49-5619-4653-b565-29a7c5ca6ca1@moroto.mountain> (raw)
In-Reply-To: <1711021557-58116-3-git-send-email-hengqi@linux.alibaba.com>
Hi Heng,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Heng-Qi/virtio-net-fix-possible-dim-status-unrecoverable/20240321-194759
base: linus/master
patch link: https://lore.kernel.org/r/1711021557-58116-3-git-send-email-hengqi%40linux.alibaba.com
patch subject: [PATCH 2/2] virtio-net: reduce the CPU consumption of dim worker
config: i386-randconfig-141-20240322 (https://download.01.org/0day-ci/archive/20240322/202403221133.J66oueZh-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
| Closes: https://lore.kernel.org/r/202403221133.J66oueZh-lkp@intel.com/
New smatch warnings:
drivers/net/virtio_net.c:5031 virtnet_probe() warn: missing error code 'err'
vim +/err +5031 drivers/net/virtio_net.c
986a4f4d452dec Jason Wang 2012-12-07 5006 /* Allocate/initialize the rx/tx queues, and invoke find_vqs */
3f9c10b0d478a3 Amit Shah 2011-12-22 5007 err = init_vqs(vi);
d2a7ddda9ffb1c Michael S. Tsirkin 2009-06-12 5008 if (err)
d7dfc5cf56b0e3 Toshiaki Makita 2018-01-17 5009 goto free;
296f96fcfc160e Rusty Russell 2007-10-22 5010
3014a0d54820d2 Heng Qi 2023-10-08 5011 if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_NOTF_COAL)) {
3014a0d54820d2 Heng Qi 2023-10-08 5012 vi->intr_coal_rx.max_usecs = 0;
3014a0d54820d2 Heng Qi 2023-10-08 5013 vi->intr_coal_tx.max_usecs = 0;
3014a0d54820d2 Heng Qi 2023-10-08 5014 vi->intr_coal_rx.max_packets = 0;
3014a0d54820d2 Heng Qi 2023-10-08 5015
3014a0d54820d2 Heng Qi 2023-10-08 5016 /* Keep the default values of the coalescing parameters
3014a0d54820d2 Heng Qi 2023-10-08 5017 * aligned with the default napi_tx state.
3014a0d54820d2 Heng Qi 2023-10-08 5018 */
3014a0d54820d2 Heng Qi 2023-10-08 5019 if (vi->sq[0].napi.weight)
3014a0d54820d2 Heng Qi 2023-10-08 5020 vi->intr_coal_tx.max_packets = 1;
3014a0d54820d2 Heng Qi 2023-10-08 5021 else
3014a0d54820d2 Heng Qi 2023-10-08 5022 vi->intr_coal_tx.max_packets = 0;
3014a0d54820d2 Heng Qi 2023-10-08 5023 }
3014a0d54820d2 Heng Qi 2023-10-08 5024
d8cd72f1622753 Heng Qi 2024-03-21 5025 INIT_LIST_HEAD(&vi->coal_list);
3014a0d54820d2 Heng Qi 2023-10-08 5026 if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_VQ_NOTF_COAL)) {
d8cd72f1622753 Heng Qi 2024-03-21 5027 vi->cvq_cmd_nums = 0;
d8cd72f1622753 Heng Qi 2024-03-21 5028 vi->dim_loop_index = 0;
d8cd72f1622753 Heng Qi 2024-03-21 5029
d8cd72f1622753 Heng Qi 2024-03-21 5030 if (virtnet_init_coal_list(vi))
d8cd72f1622753 Heng Qi 2024-03-21 @5031 goto free;
This should probably set the error code.
err = virtnet_init_coal_list(vi);
if (err)
goto free;
d8cd72f1622753 Heng Qi 2024-03-21 5032
3014a0d54820d2 Heng Qi 2023-10-08 5033 /* The reason is the same as VIRTIO_NET_F_NOTF_COAL. */
d8cd72f1622753 Heng Qi 2024-03-21 5034 for (i = 0; i < vi->max_queue_pairs; i++) {
d8cd72f1622753 Heng Qi 2024-03-21 5035 vi->rq[i].packets_in_napi = 0;
3014a0d54820d2 Heng Qi 2023-10-08 5036 if (vi->sq[i].napi.weight)
3014a0d54820d2 Heng Qi 2023-10-08 5037 vi->sq[i].intr_coal.max_packets = 1;
3014a0d54820d2 Heng Qi 2023-10-08 5038 }
d8cd72f1622753 Heng Qi 2024-03-21 5039 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-03-22 6:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 11:45 [PATCH 0/2] virtio-net: a fix and some updates for virtio dim Heng Qi
2024-03-21 11:45 ` [PATCH 1/2] virtio-net: fix possible dim status unrecoverable Heng Qi
2024-03-22 5:17 ` Jason Wang
2024-03-25 2:11 ` Heng Qi
2024-03-25 6:29 ` Jason Wang
2024-03-25 6:57 ` Heng Qi
2024-03-25 7:06 ` Jason Wang
2024-03-21 11:45 ` [PATCH 2/2] virtio-net: reduce the CPU consumption of dim worker Heng Qi
2024-03-22 2:03 ` kernel test robot
2024-03-22 5:19 ` Jason Wang
2024-03-25 2:21 ` Heng Qi
2024-03-25 5:57 ` Jason Wang
2024-03-25 7:17 ` Heng Qi
2024-03-25 7:56 ` Jason Wang
2024-03-25 8:22 ` Heng Qi
2024-03-25 8:42 ` Jason Wang
2024-03-26 2:46 ` Heng Qi
2024-03-26 4:08 ` Jason Wang
2024-03-26 5:57 ` Heng Qi
2024-03-26 6:05 ` Jason Wang
2024-03-22 6:50 ` Dan Carpenter [this message]
2024-03-21 12:25 ` [PATCH 0/2] virtio-net: a fix and some updates for virtio dim Jiri Pirko
2024-03-25 2:23 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7392d49-5619-4653-b565-29a7c5ca6ca1@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox