From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Richard Cochran <richardcochran@gmail.com>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] selftests: drv-net: extend HW timestamp test with ioctl
Date: Fri, 16 Jan 2026 06:12:06 +0000 [thread overview]
Message-ID: <b74a2241-bbbd-4c36-ad6f-1815b4838077@linux.dev> (raw)
In-Reply-To: <20260115201020.69f2a0b8@kernel.org>
On 16/01/2026 04:10, Jakub Kicinski wrote:
> On Wed, 14 Jan 2026 22:44:14 +0000 Vadim Fedorenko wrote:
>> Extend HW timestamp tests to check that ioctl interface is not broken
>> and configuration setups and requests are equal to netlink interface.
>
> Haven't looked closely but pylint is not happy (pylint --disable=R
> $file):
>
> tools/testing/selftests/drivers/net/hw/nic_timestamp.py:9:0: C0410: Multiple imports on one line (ctypes, fcntl, socket) (multiple-imports)
> tools/testing/selftests/drivers/net/hw/nic_timestamp.py:16:0: C0115: Missing class docstring (missing-class-docstring)
> tools/testing/selftests/drivers/net/hw/nic_timestamp.py:16:0: C0103: Class name "hwtstamp_config" doesn't conform to PascalCase naming style (invalid-name)
> tools/testing/selftests/drivers/net/hw/nic_timestamp.py:86:4: W0201: Attribute 'rx_filter' defined outside __init__ (attribute-defined-outside-init)
> tools/testing/selftests/drivers/net/hw/nic_timestamp.py:87:4: W0201: Attribute 'tx_type' defined outside __init__ (attribute-defined-outside-init)
> tools/testing/selftests/drivers/net/hw/nic_timestamp.py:22:0: C0115: Missing class docstring (missing-class-docstring)
> tools/testing/selftests/drivers/net/hw/nic_timestamp.py:22:0: C0103: Class name "ifreq" doesn't conform to PascalCase naming style (invalid-name)
> tools/testing/selftests/drivers/net/hw/nic_timestamp.py:56:4: W0201: Attribute 'ifr_name' defined outside __init__ (attribute-defined-outside-init)
> tools/testing/selftests/drivers/net/hw/nic_timestamp.py:89:4: W0201: Attribute 'ifr_name' defined outside __init__ (attribute-defined-outside-init)
> tools/testing/selftests/drivers/net/hw/nic_timestamp.py:57:4: W0201: Attribute 'ifr_data' defined outside __init__ (attribute-defined-outside-init)
> tools/testing/selftests/drivers/net/hw/nic_timestamp.py:90:4: W0201: Attribute 'ifr_data' defined outside __init__ (attribute-defined-outside-init)
Most of them are because of ctypes. v2 will have linter happier
next prev parent reply other threads:[~2026-01-16 6:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 22:44 [PATCH net-next 1/2] net: remove legacy way to get/set HW timestamp config Vadim Fedorenko
2026-01-14 22:44 ` [PATCH net-next 2/2] selftests: drv-net: extend HW timestamp test with ioctl Vadim Fedorenko
2026-01-15 12:03 ` Kory Maincent
2026-01-16 4:10 ` Jakub Kicinski
2026-01-16 6:12 ` Vadim Fedorenko [this message]
2026-01-15 11:58 ` [PATCH net-next 1/2] net: remove legacy way to get/set HW timestamp config Kory Maincent
2026-01-15 12:31 ` Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b74a2241-bbbd-4c36-ad6f-1815b4838077@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox