netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
	Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>,
	Andy Duan <fugang.duan@nxp.com>,
	"David S. Miller" <davem@davemloft.net>,
	Troy Kisky <troy.kisky@boundarydevices.com>,
	Eric Nelson <eric@nelint.com>,
	Philippe Reynes <tremyfr@gmail.com>,
	Johannes Berg <johannes@sipsolutions.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Chris Healy <cphealy@gmail.com>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: Re: DSA vs envelope frames
Date: Wed, 30 Nov 2016 19:26:59 -0800	[thread overview]
Message-ID: <b75a3232-bdda-6758-874f-829b3e4097e9@gmail.com> (raw)
In-Reply-To: <20161130151028.GD21645@lunn.ch>



On 11/30/2016 07:10 AM, Andrew Lunn wrote:
>> What is not really clear - what if several tagging protocols are used
>> together. AFAIU, things may be more complex that simple appending of
>> tags, e.g. EDSA tag can carry VLAN id inside.
> 
> Hi Nikita
> 
> At least for all current tagging protocols, the size of the tag is
> constant. And you cannot run different tagging protocols on the same
> master interface at the same time.

I am not sure if using envelope frames is entirely appropriate here,
because there are existing switch tagging protocols that:

- don't have a specific Ethernet type allocated (Broadcom tags, DSA)
- could be appended at the end of the frame instead of pre-pended

Alexander Duyck suggested a while ago that we may be able to use the
headers_ops to implement the DSA tag pop/push, as well as get an
appropriate MTU adjustment, can you see if that would work?

> 
> However, i think Florian tried something funky with the SF2 and B53
> driver. He has a b53 hanging off a sf2. So i think he used nested
> tagging protocols!

Well, this actually did not work, because the SF2 and B53 switches
essentially terminate switch tags when they ingress their switch ports,
so the tag inserted by B53 ingressing into the SF2 port does not get
sent all the way to the CPU hanging off the SF2... With the B53 hanging
off the SF2, we essentially have to disable Broadcom tags in the B53
device, because the tag and switches were never designed to be cascaded
in the first place (at least not these specific cores).
-- 
Florian

  reply	other threads:[~2016-12-01  3:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 18:35 [patch net / RFC] net: fec: increase frame size limitation to actually available buffer Nikita Yushchenko
2016-11-30  2:37 ` Andy Duan
2016-11-30  6:36   ` Nikita Yushchenko
2016-11-30  7:25     ` Toshiaki Makita
2016-11-30 14:58       ` DSA vs envelope frames Nikita Yushchenko
2016-11-30 15:10         ` Andrew Lunn
2016-12-01  3:26           ` Florian Fainelli [this message]
2016-12-01 12:46         ` Toshiaki Makita
2016-11-30  7:35     ` [patch net / RFC] net: fec: increase frame size limitation to actually available buffer Andy Duan
2016-11-30 16:05 ` Zefir Kurtisi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b75a3232-bdda-6758-874f-829b3e4097e9@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=cphealy@gmail.com \
    --cc=davem@davemloft.net \
    --cc=eric@nelint.com \
    --cc=fabio.estevam@nxp.com \
    --cc=fugang.duan@nxp.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=makita.toshiaki@lab.ntt.co.jp \
    --cc=netdev@vger.kernel.org \
    --cc=nikita.yoush@cogentembedded.com \
    --cc=tremyfr@gmail.com \
    --cc=troy.kisky@boundarydevices.com \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).