From: Paolo Abeni <pabeni@redhat.com>
To: "Felix Fietkau" <nbd@nbd.name>,
netdev@vger.kernel.org, "Roopa Prabhu" <roopa@nvidia.com>,
"Nikolay Aleksandrov" <razor@blackwall.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: bridge@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: bridge: fix multicast-to-unicast with fraglist GSO
Date: Tue, 30 Apr 2024 13:07:21 +0200 [thread overview]
Message-ID: <b763c28aa7cb3276136eac39a9144a4242587438.camel@redhat.com> (raw)
In-Reply-To: <20240427182420.24673-1-nbd@nbd.name>
On Sat, 2024-04-27 at 20:24 +0200, Felix Fietkau wrote:
> Calling skb_copy on a SKB_GSO_FRAGLIST skb is not valid, since it returns
> an invalid linearized skb. This code only needs to change the ethernet
> header, so pskb_copy is the right function to call here.
>
> Fixes: 6db6f0eae605 ("bridge: multicast to unicast")
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
> net/bridge/br_forward.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c
> index 7431f89e897b..d7c35f55bd69 100644
> --- a/net/bridge/br_forward.c
> +++ b/net/bridge/br_forward.c
> @@ -266,7 +266,7 @@ static void maybe_deliver_addr(struct net_bridge_port *p, struct sk_buff *skb,
> if (skb->dev == p->dev && ether_addr_equal(src, addr))
> return;
>
> - skb = skb_copy(skb, GFP_ATOMIC);
> + skb = pskb_copy(skb, GFP_ATOMIC);
> if (!skb) {
> DEV_STATS_INC(dev, tx_dropped);
> return;
LGTM, but let's wait a little more time for Nikolay
Acked-by: Paolo Abeni <pabeni@redhat.com>
next prev parent reply other threads:[~2024-04-30 11:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-27 18:24 [PATCH net 1/2] net: bridge: fix multicast-to-unicast with fraglist GSO Felix Fietkau
2024-04-27 18:24 ` [PATCH net 2/2] net: core: reject skb_copy(_expand) for fraglist GSO skbs Felix Fietkau
2024-04-30 11:07 ` Paolo Abeni [this message]
2024-05-01 9:00 ` [PATCH net 1/2] net: bridge: fix multicast-to-unicast with fraglist GSO Nikolay Aleksandrov
2024-05-01 10:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b763c28aa7cb3276136eac39a9144a4242587438.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linus.luessing@c0d3.blue \
--cc=linux-kernel@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox