From: Andrew Davis <afd@ti.com>
To: Teresa Remmet <t.remmet@phytec.de>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<upstream@lists.phytec.de>, Yannic Moog <y.moog@phytec.de>,
Benjamin Hahn <b.hahn@phytec.de>,
Yashwanth Varakala <y.varakala@phytec.de>,
Jan Remmet <j.remmet@phytec.de>
Subject: Re: [PATCH 0/2] net: phy: dp83867: add numeric impedance DT property
Date: Thu, 29 Jan 2026 11:31:29 -0600 [thread overview]
Message-ID: <b7b8f855-bf38-41ba-96c4-1bdc3a1c2cc8@ti.com> (raw)
In-Reply-To: <20260129-wip-t-remmet-phytec-de-bspimx95-132_upstream-v1-0-8deccd658d16@phytec.de>
On 1/29/26 8:13 AM, Teresa Remmet wrote:
> Introduce a new way to set the output impedance over device tree.
> So far it is possible to pass the value either over an nvmem
> cell or to set the min and max booleans over device tree.
>
We have a similar issue in our networking driver, we can either get
the MAC address though a NVMEM cell, or when that is unavailable use
fallback to using a hardcoded value in DT.
I wonder if it would make sense to add a new type of NVMEM cell that
encodes the content of the cell in DT itself..
That way we can use the same NVMEM interface in both cases, without
adding all these custom fallback properties to every NVMEM consumer.
Andrew
> In our use case we want to be able to set the impedance over
> device tree but the boolean values are not the right fit to
> provide best signal integrity for the hardware.
>
> To: Andrew Lunn <andrew+netdev@lunn.ch>
> To: David S. Miller <davem@davemloft.net>
> To: Eric Dumazet <edumazet@google.com>
> To: Jakub Kicinski <kuba@kernel.org>
> To: Paolo Abeni <pabeni@redhat.com>
> To: Rob Herring <robh@kernel.org>
> To: Krzysztof Kozlowski <krzk+dt@kernel.org>
> To: Conor Dooley <conor+dt@kernel.org>
> To: Andrew Davis <afd@ti.com>
> To: Andrew Lunn <andrew@lunn.ch>
> To: Heiner Kallweit <hkallweit1@gmail.com>
> To: Russell King <linux@armlinux.org.uk>
> Cc: netdev@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Cc: upstream@lists.phytec.de
>
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> ---
> Teresa Remmet (2):
> dt-bindings: dp83867: add binding for ti,output-impedance property
> net: phy: dp83867: add numeric io impedance DT property
>
> Documentation/devicetree/bindings/net/ti,dp83867.yaml | 19 ++++++++++++++-----
> drivers/net/phy/dp83867.c | 17 +++++++++++++----
> 2 files changed, 27 insertions(+), 9 deletions(-)
> ---
> base-commit: 1f97d9dcf53649c41c33227b345a36902cbb08ad
> change-id: 20260128-wip-t-remmet-phytec-de-bspimx95-132_upstream-48188a567544
>
> Best regards,
next prev parent reply other threads:[~2026-01-29 17:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 14:13 [PATCH 0/2] net: phy: dp83867: add numeric impedance DT property Teresa Remmet
2026-01-29 14:13 ` [PATCH 1/2] dt-bindings: dp83867: add binding for ti,output-impedance property Teresa Remmet
2026-02-10 14:48 ` Rob Herring
2026-02-11 12:50 ` Teresa Remmet
2026-02-11 14:02 ` Andrew Lunn
2026-02-17 13:51 ` Teresa Remmet
2026-01-29 14:13 ` [PATCH 2/2] net: phy: dp83867: add numeric io impedance DT property Teresa Remmet
2026-01-29 16:25 ` Jakub Kicinski
2026-01-29 17:31 ` Andrew Davis [this message]
2026-02-10 14:42 ` [PATCH 0/2] net: phy: dp83867: add numeric " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7b8f855-bf38-41ba-96c4-1bdc3a1c2cc8@ti.com \
--to=afd@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=b.hahn@phytec.de \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=j.remmet@phytec.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=t.remmet@phytec.de \
--cc=upstream@lists.phytec.de \
--cc=y.moog@phytec.de \
--cc=y.varakala@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox