From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net-next] i40e: remove inline directive Date: Mon, 3 Sep 2018 19:05:05 +0300 Message-ID: References: <20180903123621.8696-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org To: YueHaibing , davem@davemloft.net, jeffrey.t.kirsher@intel.com Return-path: Received: from mail-lj1-f196.google.com ([209.85.208.196]:45256 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727223AbeICUZz (ORCPT ); Mon, 3 Sep 2018 16:25:55 -0400 Received: by mail-lj1-f196.google.com with SMTP id u83-v6so818523lje.12 for ; Mon, 03 Sep 2018 09:05:08 -0700 (PDT) In-Reply-To: <20180903123621.8696-1-yuehaibing@huawei.com> Content-Language: en-MW Sender: netdev-owner@vger.kernel.org List-ID: On 09/03/2018 03:36 PM, YueHaibing wrote: > Fixes follow gcc warning: > > drivers/net/ethernet/intel/i40e/i40e_ethtool.c: In function '__i40e_add_stat_strings': > drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h:193:20: error: function '__i40e_add_stat_strings' can never be inlined because it uses variable argument lists > > Fixes: 8fd75c58a09a ("i40e: move ethtool stats boiler plate code to i40e_ethtool_stats.h") > Signed-off-by: YueHaibing > --- > drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h b/drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h > index bba1cb0..0290ade 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h > +++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool_stats.h > @@ -190,7 +190,7 @@ i40e_add_queue_stats(u64 **data, struct i40e_ring *ring) > * Format and copy the strings described by stats into the buffer pointed at > * by p. > **/ > -static inline void __i40e_add_stat_strings(u8 **p, const struct i40e_stats stats[], > +static void __i40e_add_stat_strings(u8 **p, const struct i40e_stats stats[], > const unsigned int size, ...) > { > unsigned int i; You now need to move this function to a .c file and leave here only its prototype. MBR, Sergei