From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: David Miller <davem@davemloft.net>, dsahern@gmail.com
Cc: netdev@vger.kernel.org, sharpd@cumulusnetworks.com
Subject: Re: [PATCH net-next] fib_rules: rename FRA_PROTOCOL to FRA_ORIGINATOR
Date: Wed, 21 Mar 2018 16:51:47 +0100 [thread overview]
Message-ID: <b7c2075a-bfcd-81fe-fa71-9486f6b8909f@6wind.com> (raw)
In-Reply-To: <20180321.111552.1322071853274264739.davem@davemloft.net>
Le 21/03/2018 à 16:15, David Miller a écrit :
> From: David Ahern <dsahern@gmail.com>
> Date: Wed, 21 Mar 2018 09:00:09 -0600
>
>> The rule->proto value is not used as a selector. It is passed in, stored
>> on a rule and returned to userspace. It is book keeping only so an admin
>> has some idea of which program installed the rule.
>
> This is how I understand this value to work as well.
>
Me too, and it's the reason why I propose to rename it, to make this clear.
'originator' is a lot more explicit than 'proto'.
next prev parent reply other threads:[~2018-03-21 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 17:04 [PATCH net-next] fib_rules: rename FRA_PROTOCOL to FRA_ORIGINATOR Nicolas Dichtel
2018-03-20 17:27 ` David Ahern
2018-03-21 9:24 ` Nicolas Dichtel
2018-03-21 15:00 ` David Ahern
2018-03-21 15:15 ` David Miller
2018-03-21 15:51 ` Nicolas Dichtel [this message]
2018-03-22 16:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7c2075a-bfcd-81fe-fa71-9486f6b8909f@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sharpd@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).