From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com ([74.125.82.41]:53422 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbeCUPvu (ORCPT ); Wed, 21 Mar 2018 11:51:50 -0400 Received: by mail-wm0-f41.google.com with SMTP id e194so10578433wmd.3 for ; Wed, 21 Mar 2018 08:51:50 -0700 (PDT) Reply-To: nicolas.dichtel@6wind.com Subject: Re: [PATCH net-next] fib_rules: rename FRA_PROTOCOL to FRA_ORIGINATOR References: <73742889-4982-410f-2128-82dcd85f1147@gmail.com> <74299bf5-ea7f-eaa9-25de-fd485fd6f9ad@6wind.com> <20180321.111552.1322071853274264739.davem@davemloft.net> To: David Miller , dsahern@gmail.com Cc: netdev@vger.kernel.org, sharpd@cumulusnetworks.com From: Nicolas Dichtel Message-ID: Date: Wed, 21 Mar 2018 16:51:47 +0100 MIME-Version: 1.0 In-Reply-To: <20180321.111552.1322071853274264739.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org List-ID: Le 21/03/2018 à 16:15, David Miller a écrit : > From: David Ahern > Date: Wed, 21 Mar 2018 09:00:09 -0600 > >> The rule->proto value is not used as a selector. It is passed in, stored >> on a rule and returned to userspace. It is book keeping only so an admin >> has some idea of which program installed the rule. > > This is how I understand this value to work as well. > Me too, and it's the reason why I propose to rename it, to make this clear. 'originator' is a lot more explicit than 'proto'.