From: Heiner Kallweit <hkallweit1@gmail.com>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: ethtool 5.7: netlink ENOENT error when setting WOL
Date: Mon, 15 Jun 2020 00:35:30 +0200 [thread overview]
Message-ID: <b7c7634e-8912-856a-9590-74bd3895d1ed@gmail.com> (raw)
In-Reply-To: <20200610115350.wyba5rnpuavkzdl5@lion.mk-sys.cz>
On 10.06.2020 13:53, Michal Kubecek wrote:
> On Wed, Jun 10, 2020 at 12:50:30PM +0200, Heiner Kallweit wrote:
>> On 10.06.2020 11:13, Michal Kubecek wrote:
>>> Just to make sure you are hitting the same problem I'm just looking at,
>>> please check if
>>>
>>> - your kernel is built with ETHTOOL_NETLINK=n
>>
>> No, because I have PHYLIB=m.
>> Not sure what it would take to allow building ethtool netlink support
>> as a module. But that's just on a side note.
>
> Yes, this is the unfortunate fallout of the new dependency between
> ETHTOOL_NETLINK and PHYLIB introduced with the cable diagnostic series.
> As "make oldconfig" silently disables ETHTOOL_NETLINK when PHYLIB=m,
> many people won't even notice. Even I fell for this when I suddently
> noticed my testing merge window snapshot has ETHTOOL_NETLINK disable.
> I guess we will have to find some nicer solution.
>
Seems that disabling ETHTOOL_NETLINK for PHYLIB=m has (at least) one
more side effect. I just saw that ifconfig doesn't report LOWER_UP
any longer. Reason seems to be that the ioctl fallback supports
16 bits for the flags only (and IFF_LOWER_UP is bit 16).
See dev_ifsioc_locked().
> Michal
>
Heiner
next prev parent reply other threads:[~2020-06-14 22:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 8:26 ethtool 5.7: netlink ENOENT error when setting WOL Heiner Kallweit
2020-06-10 8:52 ` Heiner Kallweit
2020-06-10 9:13 ` Michal Kubecek
2020-06-10 10:50 ` Heiner Kallweit
2020-06-10 11:53 ` Michal Kubecek
2020-06-14 22:35 ` Heiner Kallweit [this message]
2020-06-14 23:26 ` Michal Kubecek
2020-06-15 6:20 ` Heiner Kallweit
2020-06-10 15:27 ` Florian Fainelli
2020-06-10 20:05 ` Andrew Lunn
2020-06-14 16:14 ` Heiner Kallweit
2020-06-14 16:44 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7c7634e-8912-856a-9590-74bd3895d1ed@gmail.com \
--to=hkallweit1@gmail.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).