From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D28A9C76195 for ; Mon, 22 Jul 2019 08:37:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC7682229A for ; Mon, 22 Jul 2019 08:37:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IGFPYI95" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728532AbfGVIg6 (ORCPT ); Mon, 22 Jul 2019 04:36:58 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:45527 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728323AbfGVIg5 (ORCPT ); Mon, 22 Jul 2019 04:36:57 -0400 Received: by mail-pf1-f195.google.com with SMTP id r1so17024113pfq.12; Mon, 22 Jul 2019 01:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j6w1h6MOwLx1qltjlCykcB2n5pu6k9XFgBYb35I9b94=; b=IGFPYI95Yb/GP16xfTIPeMHOM4JZYhsIMYXmvzlUFQvJnz8C2K2+EZLuYeSUXn3mh8 DnJ27UJRGlz9Wyi1P/MH7Qo72mdobaeMo9ZMOeg2dtwt0Aqt6WEe962Cx6bVt4rSkYZY GmUbpGREiGiEZzhpOsCQnOCdxsqifZ/L6Nhldq9GuFCCDGOExgLtfzJseBGlWHyzkrxH uZSQkqZozxEuT8aLxtVjcCEl8p13FwH/Ts2OKFHaKXakk8Oq4oywxPiND4DhYGSpTjVC hSSNUSBKr1bmbMoKUiZ1pl78Z/MoXGBxLnaDhHVg+c39xcL00UpBW8hwevZiR2kBawGB WEcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j6w1h6MOwLx1qltjlCykcB2n5pu6k9XFgBYb35I9b94=; b=E/az6RSSyFS48IUhjgeJoGkg5AMjObZFWtSLHVRaoN97+wfeK3aCqom1tc18tul8qU hSoBZXs3Nheen4x5ODl0z15UQua/8iZPfSmZjRMdjMonAfrGBLePEN9pIJUAz5n+C6pi Tbm2Ets+76c5nxNKSGpChW4medlVbqvYLquBn6m/19meBNyP+/QiKWNtuH01rz2XZ4jk q/sxyLj4ntEwF0atU57ODpppvTTwObDENlVcgjgTznqKaSWtyyKAgcQz3Qk2AsdvXwOA Rc2iZNyycEdTy6BolULmeHZZo1nNy6D6ii1OzHNFHfiNTfCkYx1JhxxR5V57CjsRnBD2 dapw== X-Gm-Message-State: APjAAAW/RgHcgDFxNWRG6swmfntb/DLIWwGyPYLxt0CCOm+jSw/4pObX WpZRxCG6eC68fP4x5NQpEtr7GL8f X-Google-Smtp-Source: APXvYqxE9h+fM7hcGw7JD2QwWIjJ8hmgwvIvIoFYZ/ar+5y04cBEhjutBjzwJdZVdcq4Aspr0xQZRA== X-Received: by 2002:a63:e901:: with SMTP id i1mr54098401pgh.451.1563784616653; Mon, 22 Jul 2019 01:36:56 -0700 (PDT) Received: from [192.168.1.38] (59-120-186-245.HINET-IP.hinet.net. [59.120.186.245]) by smtp.gmail.com with ESMTPSA id a3sm33784096pfl.145.2019.07.22.01.36.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jul 2019 01:36:56 -0700 (PDT) Subject: Re: [PATCH V2 1/1] can: sja1000: f81601: add Fintek F81601 support To: Marc Kleine-Budde , wg@grandegger.com, peter_hong@fintek.com.tw Cc: davem@davemloft.net, f.suligoi@asem.it, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, "Ji-Ze Hong (Peter Hong)" References: <1563776521-28317-1-git-send-email-hpeter+linux_kernel@gmail.com> <563b0d71-3c60-d32c-cf19-73611f68d45a@pengutronix.de> From: "Ji-Ze Hong (Peter Hong)" Message-ID: Date: Mon, 22 Jul 2019 16:36:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <563b0d71-3c60-d32c-cf19-73611f68d45a@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Marc, Marc Kleine-Budde 於 2019/7/22 下午 04:15 寫道: > On 7/22/19 8:22 AM, Ji-Ze Hong (Peter Hong) wrote: >> +/* Probe F81601 based device for the SJA1000 chips and register each >> + * available CAN channel to SJA1000 Socket-CAN subsystem. >> + */ >> +static int f81601_pci_add_card(struct pci_dev *pdev, >> + const struct pci_device_id *ent) >> +{ >> + struct sja1000_priv *priv; >> + struct net_device *dev; >> + struct f81601_pci_card *card; >> + int err, i, count; >> + u8 tmp; >> + >> + if (pcim_enable_device(pdev) < 0) { > > I'm missing a corresponding disable_device(). > I'm using managed pcim_enable_device(), Does it need call pci_disable_device() ?? Thanks -- With Best Regards, Peter Hong