From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 73842314B72 for ; Thu, 8 Oct 2026 05:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791437388; cv=none; b=NjY8u/m9vrermbf0f+NpIJSgzhm3FsulX3WyrnogcetyTBtOjC6LKqACTwa9O43nYSNq4U5eMhefLFApKLq06Lytn1EUlNHZvR5qeokvkLg7h6awu1DEWzSBpmwYXK/z2IKgS1aOBOYM64HD5ge0r18O0IUB9lYtD74LXhYheLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791437388; c=relaxed/simple; bh=psF77OoksKyKszlVeKZVEcGxdgyZQCg4lQ4qS9TLvj4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=srRqNy7pjxHUMfVCMcgXxL6+uz1NNpcdnzutOHnT0vdTY6Z0hcCMZsr/tP1LZdW7J4VhNqCnhF3qknV5OiO2GONjbpvwZtaV2W/Syu9EHGya6NQjnrp0QjR109/NUat2fE/m1KlmXBJp5phf+VciOT1ssssKcFhwxsL8c4aoEHQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XLykfNY3; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XLykfNY3" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-3ab066bef7dso102791a91.1 for ; Wed, 07 Oct 2026 22:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791437386; x=1792042186; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tNMJn/lOvJR8pkwjdlZTd33Az5DYUmJYI23RTsbII4o=; b=XLykfNY3osHZuek4PDYA4haYFOXe8nEllRKqvHLZVsXckFvDUe3oZR8qP4GSaPwaMI WbG8xdD6YVCvX0/IMkFcpbbv9hFwfeXAaIz1gnIatJ87eT97gY5CN3cw69+xr3kNHtWZ Ud/O4yP66wz0KtkWDCYx1GvGCSOno+DL2rsmEpjJgtpqlO/SwLi2KOrC9YgZ9Dzl3o8v 5G1g7DK+kz0xqrxPX2sICPSV92+RGh8/nHlcMTa6j9DRO3oov2iacIYgKwd7fZqOOW5q 3TK/tV1SMEiRnN9kv+gP6UtbmRGyI5/zWflHtGQbjb28G6RzY00Ez61rCcYqkkHbj/11 eotg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791437386; x=1792042186; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tNMJn/lOvJR8pkwjdlZTd33Az5DYUmJYI23RTsbII4o=; b=KIylH95GQrs3mP8Tig6Karo0H7YoComHO0N2zLnMjFW1f4qANR4iD/9vV33fVIJDVa FEp5oj6TcOR9bd2sSerQBfLTElyxRDg2awkUZ71HkQVVxm574BaFd1jdFYrbEdU6oAB+ /+ZsmKh7gLcd5xDP2gzkYmML6k3bjraS91Fxt5W8BUPTp4SRubo+dtOCI5vqOXbeTN37 MvJfU0ZmRDQtUuwAY+t+FUuI1PQqEHp4C4MwcN6FCchtfEog41PPWARipbecwvS+3pjf NV5coiJhAW41NM57AF5i2mMGyXRdISQAg+rUKYIod2LsUQLkA7AqbYVd9bfg0WvBFZPo 65fQ== X-Forwarded-Encrypted: i=1; AKwUvBwsGlCCIwJGeLgWPWYaHFptpxbJTMyY5ssVkoPSdUauALn9wUTOlILkZFjSbV3r2lAUM8Uw8U8=@vger.kernel.org X-Gm-Message-State: AFq9FYKUmSRtefJMi73oJvMny4XjT4mdrGtxKPwDEr77W2LUrGegXX1o bNEZITWcrMhKMeIiTrTmkjQPOZjkT2Rj89ZRhI4cegj/z/al5yvK5X2I X-Gm-Gg: AYBFou3RpUueOPUQ71k9HJbztKVVwFDujyVxhdwKB3Qe7ohD3VFE5J+j55cED1srZnc 1gVuzhAKHtlX4Q1D3Z1T0mCYjAj1Z12PqGy41LdeBYt83ozUDgG56srwVKui67csRb5ioU/LLsp SnFj+877cJtBVKvysoYaShVga35ZYBlxBeq/sQxbVwB2mQpKUxllArP8miTRLBqNwEnPCGmGuwj GVM2sS4NM+lFatb8jgkLvBJz+IQibIQL5pPB17sW/spkvqUvR+QpbL85+RSI3jkpdJUAERaQKzp r8COdaA4ClzIyhZU+wUFLVvEXxNtyPb/5zdaRkcd4k0GvmdL7kThXJXJZ9DDpmZCDjOi2NfsH54 +G62ZbtcAeJjcdqUbfT0IiFMuJsOnVLNRtYJCzfl7FTUHvB0HT2cDQDuNjoQ1jK3i/vzP3xPSHb oARmu3FnmbuzpL0wjtDww0RnfDefXLTgsMV/L70OECsrIyP9j9oi30DWll57kLDMGg0nDhiI8NX QbtaTP8Dm4= X-Received: by 2002:a17:90b:4fc5:b0:3a8:5fd6:cb6 with SMTP id 98e67ed59e1d1-3a89f4441femr4035599a91.0.1791437385760; Wed, 07 Oct 2026 22:29:45 -0700 (PDT) Received: from ancienth-X870E-Nova-WiFi ([125.186.72.2]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a89dcc4e04sm3758223a91.1.2026.10.07.22.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 22:29:45 -0700 (PDT) From: Daehyeon Ko <4ncienth@gmail.com> To: David Ahern , Ido Schimmel Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Amit Cohen , Roopa Prabhu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Daehyeon Ko <4ncienth@gmail.com> Subject: [PATCH net v2 1/2] ipv4: do not warn on route notification size race Date: Thu, 8 Oct 2026 14:29:22 +0900 Message-ID: X-Mailer: git-send-email 2.55.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 680aea08e78c ("net: ipv4: Emit notification when fib hardware flags are changed") added asynchronous route notifications for hardware flag changes. fib_alias_hw_flags_set() sizes the skb with fib_nlmsg_size() and later fills it with fib_dump_info() while holding only RCU. With nexthop compatibility mode enabled, a concurrent replacement can grow the group between these independent snapshots. fib_dump_info() can then legitimately return -EMSGSIZE, so the warning does not prove a sizing bug. Remove the warning. The existing error path still frees the skb and reports the error to listeners. Fixes: 680aea08e78c ("net: ipv4: Emit notification when fib hardware flags are changed") Reported-by: Ido Schimmel Link: https://lore.kernel.org/netdev/20261004082043.GB92032@shredder/ Suggested-by: Ido Schimmel Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Daehyeon Ko <4ncienth@gmail.com> --- net/ipv4/fib_trie.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c index acb1e43859143e..248514dce0cdd5 100644 --- a/net/ipv4/fib_trie.c +++ b/net/ipv4/fib_trie.c @@ -1079,8 +1079,6 @@ void fib_alias_hw_flags_set(struct net *net, const struct fib_rt_info *fri) err = fib_dump_info(skb, 0, 0, RTM_NEWROUTE, fri, 0); if (err < 0) { - /* -EMSGSIZE implies BUG in fib_nlmsg_size() */ - WARN_ON(err == -EMSGSIZE); kfree_skb(skb); goto errout; } -- 2.55.0