From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksandr Natalenko Subject: Re: CAKE and r8169 cause panic on upload in v4.19 Date: Fri, 26 Oct 2018 22:54:12 +0200 Message-ID: References: <61d09f0db41f269cc9ee13dd68a5c285@natalenko.name> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Cc: hkallweit1@gmail.com, =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , "David S. Miller" , Jamal Hadi Salim , Cong Wang , =?UTF-8?Q?Ji?= =?UTF-8?Q?=C5=99=C3=AD_P=C3=ADrko?= , Linux Kernel Network Developers , linux-kernel@vger.kernel.org To: Dave Taht Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hi. On 26.10.2018 22:25, Dave Taht wrote: > Can you repeat your test, disabling gro splitting in cake? > > the option is "no-split-gso" Still panics. Takes a couple of rounds, but panics. Moreover, I've stressed my HTB setup like this too for a longer time, and it panics as well. So, at least, now I have a proof this is not a CAKE-specific thing. Also, I've stressed it even with noqueue, and the panic is still there. So, this thing is not even sch-specific. Next, I've seen GRO bits in the call trace and decided to disable GRO on this NIC. So far, I cannot trigger a panic with GRO disabled even after 20 rounds of speedtest. So, must be some generic thing indeed. -- Oleksandr Natalenko (post-factum)