From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net-next] net/trace: fix printk format in inet_sock_set_state Date: Sat, 23 Dec 2017 12:42:03 +0300 Message-ID: References: <1513957033-24100-1-git-send-email-laoar.shao@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org To: Yafang Shao Return-path: Received: from mail-lf0-f65.google.com ([209.85.215.65]:44257 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750713AbdLWJmG (ORCPT ); Sat, 23 Dec 2017 04:42:06 -0500 Received: by mail-lf0-f65.google.com with SMTP id g63so11769102lfl.11 for ; Sat, 23 Dec 2017 01:42:05 -0800 (PST) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 12/23/2017 4:10 AM, Yafang Shao wrote: >>> There's a space character missed in the printk messages. >>> This error should be prevented with checkscript.pl, but it couldn't caught > It is checkpatch.pl. Yes, that too. But I actually meant you missed "be" between "couldn't" and "caught"... >>> by running with "checkscript.pl -f xxxx.patch", that's what I had run >>> before. >>> What a carelessness. >> You generally don't need to break up the messages violating 80-column >> limit, and checkpatch.pl should be aware of this... > Oh. That's right. > It can be aware of that. It is aware --- I'm just not sure it recognizes TP_printk() -- like it does recognize printk() fo that purpose. > I just want to make the code easy to read and limit the textwidth to > 80 character. Contrariwise, that's what you shouldn't do. Would simplify searching for the messages in the kernel source. > If the message takes two lines as bellow, > printk("xxx " > ^ space character. > "yyy"); > The checkpatch.pl could also be aware of that if the first line is > not end with space character, but it couldn't be aware of that if run > with "checkpatch.pl -f xxxx.patch". Option -f tells checkpatch.pl that it should check a source file, not a patch. I don't know why you use that with the patches... >>> Fixes: 563e0bb0dc74("net: tracepoint: replace tcp_set_state tracepoint >>> with >>> inet_sock_set_state tracepoint") >>> Signed-off-by: Yafang Shao [...] MBR, Sergei