From: Sagi Grimberg <sagi@grimberg.me>
To: Bart Van Assche <bvanassche@acm.org>, David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 6/7] net/core: Declare a local function 'static'
Date: Thu, 21 Mar 2019 15:25:07 -0700 [thread overview]
Message-ID: <b8a332e5-ce6e-a882-4ef2-4334a159fbeb@grimberg.me> (raw)
In-Reply-To: <20190321221946.163803-7-bvanassche@acm.org>
This can be dropped. Dave merged a fix for it already
On 3/21/19 3:19 PM, Bart Van Assche wrote:
> This patch avoids that the compiler complains about a missing prototype
> when building with W=1.
>
> Cc: Sagi Grimberg <sagi@grimberg.me>
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> net/core/datagram.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/core/datagram.c b/net/core/datagram.c
> index c42f1f0e62b6..334e0a7ce940 100644
> --- a/net/core/datagram.c
> +++ b/net/core/datagram.c
> @@ -410,6 +410,7 @@ int skb_kill_datagram(struct sock *sk, struct sk_buff *skb, unsigned int flags)
> }
> EXPORT_SYMBOL(skb_kill_datagram);
>
> +static
> int __skb_datagram_iter(const struct sk_buff *skb, int offset,
> struct iov_iter *to, int len, bool fault_short,
> size_t (*cb)(const void *, size_t, void *, struct iov_iter *),
>
next prev parent reply other threads:[~2019-03-21 22:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 22:19 [PATCH 0/7] net/core patches for kernel v5.2 Bart Van Assche
2019-03-21 22:19 ` [PATCH 1/7] net/core: Document reuseport_add_sock() bind_inany argument Bart Van Assche
2019-03-21 22:19 ` [PATCH 2/7] net/core: Document all dev_ioctl() arguments Bart Van Assche
2019-03-21 22:19 ` [PATCH 3/7] net/core: Document __skb_flow_dissect() flags argument Bart Van Assche
2019-03-21 22:19 ` [PATCH 4/7] net/core: Fix rtnetlink kernel-doc headers Bart Van Assche
2019-03-21 22:19 ` [PATCH 5/7] net/core: Allow the compiler to verify declaration and definition consistency Bart Van Assche
2019-03-21 22:19 ` [PATCH 6/7] net/core: Declare a local function 'static' Bart Van Assche
2019-03-21 22:25 ` Sagi Grimberg [this message]
2019-03-21 22:19 ` [PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it Bart Van Assche
2019-03-21 22:24 ` Sagi Grimberg
2019-03-22 18:46 ` Rustad, Mark D
2019-03-25 15:55 ` Bart Van Assche
2019-03-24 0:47 ` [PATCH 0/7] net/core patches for kernel v5.2 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8a332e5-ce6e-a882-4ef2-4334a159fbeb@grimberg.me \
--to=sagi@grimberg.me \
--cc=bvanassche@acm.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).